Skip to content

UpdateServiceDsc: Update localization strings #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2024
Merged

UpdateServiceDsc: Update localization strings #79

merged 2 commits into from
Jun 10, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 9, 2024 •
edited
Loading

Pull Request (PR) description

  • UpdateServicesApprovalRule
    • Updated to load localization strings correctly.
  • UpdateServicesCleanup
    • Updated to load localization strings correctly.
  • UpdateServicesServer
    • Updated to load localization strings correctly.

This Pull Request (PR) fixes the following issues

Blocking PR's.

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jun 9, 2024
@johlju johlju mentioned this pull request Jun 9, 2024
Open
9 tasks
Borgquite
Borgquite reviewed Jun 9, 2024
View reviewed changes
Copy link
Contributor

@Borgquite Borgquite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved

Borgquite
Borgquite reviewed Jun 9, 2024
View reviewed changes
Copy link
Contributor

@Borgquite Borgquite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

Borgquite
Borgquite reviewed Jun 9, 2024
View reviewed changes
@johlju
Copy link
Member Author

johlju commented Jun 9, 2024

Will fix those tomorrow. Not at a computer right now so can't merge anyway.

@johlju johlju merged commit 9d4e7c1 into dsccommunity:main Jun 10, 2024
4 of 5 checks passed
@johlju johlju deleted the fix/localization branch June 10, 2024 14:13
@johlju johlju removed the needs review The pull request needs a code review. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borgquite Borgquite Borgquite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johlju @Borgquite