Skip to content

BREAKING CHANGE: xDnsServerSetting: Remove properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 28, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #244 (e559da6) into main (9860299) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #244   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        14     14           
  Lines      1484   1484           
===================================
  Hits       1348   1348           
  Misses      136    136           
Impacted Files Coverage Δ
...ces/DSC_DnsServerSetting/DSC_DnsServerSetting.psm1 97% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 3b9df3c into dsccommunity:main Mar 31, 2021
@johlju johlju deleted the f/issue-197 branch March 31, 2021 18:53
@johlju johlju removed the needs review The pull request needs a code review. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BREAKING CHANGE: xDnsServerSetting: Remove properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL
1 participant