Skip to content

BREAKING CHANGE: xDnsServerSetting: Remove properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johlju opened this issue Mar 1, 2021 · 2 comments · Fixed by #244
Closed

BREAKING CHANGE: xDnsServerSetting: Remove properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL #197

johlju opened this issue Mar 1, 2021 · 2 comments · Fixed by #244
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Milestone
v3.0.0

Comments

@johlju
Copy link
Member

johlju commented Mar 1, 2021 •
edited
Loading

Details of the scenario you tried and the problem that is occurring

Suggest removing the properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL from the resource xDnsServerSetting to avoid ping-pong behavior. Instead those should be enforced by the resource DnsServerCache.

Verbose logs showing the problem

n/a

Suggested solution to the issue

See above. Related to issue #196 .

The DSC configuration that is used to reproduce the issue (as detailed as possible)

n/a

The operating system the target node is running

Any Windows

Version and build of PowerShell the target node is running

Windows PowerShell

Version of the DSC module that was used

2.0.0 preview
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. on hold The issue or pull request has been put on hold by a maintainer. labels Mar 1, 2021
@johlju
Copy link
Member Author

johlju commented Mar 1, 2021

Waiting for the issue #196 to be resolved.

@johlju johlju mentioned this issue Mar 7, 2021
Closed
@johlju johlju changed the title BREAKING CHANGE: xDnsServerSetting: Remove properties MaxCacheTTL and MaxNegativeCacheTTL BREAKING CHANGE: xDnsServerSetting: Remove properties MaxCacheTTL and MaxNegativeCacheTTL Mar 20, 2021
@johlju johlju added this to the v3.0.0 milestone Mar 25, 2021
@johlju johlju changed the title BREAKING CHANGE: xDnsServerSetting: Remove properties MaxCacheTTL and MaxNegativeCacheTTL BREAKING CHANGE: xDnsServerSetting: Remove properties SecureResponses, MaxCacheTTL, and MaxNegativeCacheTTL Mar 25, 2021
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Mar 27, 2021
@johlju
Copy link
Member Author

johlju commented Mar 27, 2021

The DnsServerCache parameters EnablePollutionProtection, MaxTtl and MaxNegativeTtl replaces the properties SecureResponses, MaxCacheTTL and MaxNegativeCacheTTL in the resource xDnsServerSetting,

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 28, 2021
@johlju johlju mentioned this issue Mar 28, 2021
Merged
9 tasks
johlju added a commit that referenced this issue Mar 31, 2021
@johlju
BREAKING CHANGE: xDnsServerSetting: Remove properties `SecureResponse…
3b9df3c 
…s`, `MaxCacheTTL`, and `MaxNegativeCacheTTL` (#244)

- DnsServerDsc
  - BREAKING CHANGE: The properties `SecureResponses`, `MaxCacheTTL`, and
    `MaxNegativeCacheTTL` has been removed (issue #197). To enforce theses
    properties, use resource _DnsServerEDns_ using the properties
    `EnablePollutionProtection`, `MaxTtl`, and `MaxNegativeTtl` respectively.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
v3.0.0
1 participant
@johlju