[Mysql]: (Feature) Removed .fullJoin() from MySQL Api. #1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new type MySqlJoinType which excludes the option for full joins and is used in the MySQL query builder createJoin function instead of the regular JoinType. Also removed two MySQL select type-tests which included the fullJoin function
ItayBenAmi
changed the title
…to feature/remove_full_join_from_mysql
Sukairo-02
approved these changes
Apr 8, 2025
…izzle-orm into feature/remove_full_join_from_mysql
AndriiSherman
added a commit
that referenced
this pull request
Apr 24, 2025
* Add support for cross join (#1669) * Add cross join support * Add cross join tests * Updated docs links (docs TBD) * Merged cross join function types into join function types, fixed missing cases for `cross` join type, ordered `crossJoin` test queries * `onIndex` support for `MySQL` `crossJoin`, fixed lack of `onIndex` param description in JSDoc, additional tests, disabled test case failing due to driver's issue --------- Co-authored-by: Sukairo-02 <[email protected]> * Export `PgTextBuilderInitial` type (#1286) * MySQL: Removed .fullJoin() from MySQL Api (#1351) Added new type MySqlJoinType which excludes the option for full joins and is used in the MySQL query builder createJoin function instead of the regular JoinType. Also removed two MySQL select type-tests which included the fullJoin function Co-authored-by: Sukairo-02 <[email protected]> * [Pg] Add support for left and inner lateral join in postgres (#1079) * feat: added support for left and inner lateral join in postgres Signed-off-by: Alex Vukadinov <[email protected]> * chore: updated method descriptions on the new joins Signed-off-by: Alex Vukadinov <[email protected]> * GH-420 allowing sql inside lateral joins and revert package.json * GH-420 reverted package.json empty line at the end * Changed JSDoc [WIP], reversed check --------- Signed-off-by: Alex Vukadinov <[email protected]> Co-authored-by: Sukairo-02 <[email protected]> * Completed `left`, `inner`, `cross` lateral joins in `postgresql`, `mysql`, `gel`, `singlestore`, disabled implicit `schema.table` prefixes in column selections on single table selections for `gel` due to possible errors in subqueries on column name matches in inner and outer queries, added\altered related tests * [SingleStore] Add Connection Attributes and Fix Options (#4417) * add connection attributes to SingleStore driver connection * fix allowing connection strings/options rather than external pool --------- Co-authored-by: Andrii Sherman <[email protected]> * Fix for #2654, related tests (#4353) * Dprint * Bumped version, added changelog, fixed broken test case * fix(3554) Correct spelling of `nowait` flag (#3555) * Fixed `nowait` in `Gel`, `SingleStore`, added change to changelog * Updated changelog * Fixed broken test case * Fixed `nowait` tests in `bun-sql`, `mysql-prefixed` * Add changelog updates --------- Signed-off-by: Alex Vukadinov <[email protected]> Co-authored-by: L-Mario564 <[email protected]> Co-authored-by: Dan Imhoff <[email protected]> Co-authored-by: Itay Ben-Ami <[email protected]> Co-authored-by: Alex Vukadinov <[email protected]> Co-authored-by: Mitchell Adair <[email protected]> Co-authored-by: Andrii Sherman <[email protected]> Co-authored-by: Jacob Elder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1125, following #1091.
MySqlJoinTypewhich excludes the option for full joins.createJoinfunction instead of the regularJoinType..fullJoin()can no longer be used in a MySQL query.