-
-
Notifications
You must be signed in to change notification settings - Fork 861
[BUG]: TypeScript error on optional fields during update (and insert) operation #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We encountered this same issue with: Database: Postgresql We attempted to pin to a Drizzle ORM 0.31.0 to wait for a fix and discovered that we can't use Drizzle Kit if we do that. |
Experiencing the same issue. |
Same here I suggest to use export type PgUpdateSetSource = { |
I was facing the same problem when upgrading to version >0.31.4, there's a post in discord where rphlmr said that you need ps: I needed to remove all other strict tags and let only strict tag true. |
While this does seem to fix the issue, I'd argue that this is an incredibly disruptive change to make to a project when it was not a requirement before now. Hopefully this can be resolved without resorting to flipping |
same issue |
I have the same issue. Environment:
Temporary workaround: |
Has there being any fix to this bug? I don't want to turn on strict mode in my tsconfig.json |
Same issue please give me solution. any update to fix this issue ? |
Any solution, I am also facing same issue? |
I found the solution guys. Just go to the tsconfig.json file, in the compiler options object add below line. |
this also not working! |
Are you guys sure? Because I got stuck for so many days, and this thing solves the issue, I can also insert nullable values and typescript also auto complete table variable name |
Can you guys share you tsconfig file? |
Unfortunately, I decided not to upgrade the drizzle-orm and drizzle-kit packages since I don't want to change the typescript configs, which would cause a lot of other troubles in the project. Here, I'm using drizzle-kit@^0.22.8 and drizzle-orm@^0.31.4. |
Changing it to strict worked for me to. (Postrgres and Drizzle-orm 0.33) I was confused because it was working just fine in another project but I had already turned strict on for Acktypes |
That's not a fix. I'm not going to rewrite a 20k LoC codebase to work with strict null checking just to make this work. |
The problem with using the strict option on TypeScript is that, depending on the size of your code base, you will be forced to update a lot of things. This is really annoying. |
I was going crazy after updating Drizzle to the latest version. Fortunately I've found that thread, maybe adding a notice in docs beside installation section would help users that were using Drizzle without ts strict mode. |
It seems to have gotten better with the 0.34 release. In our codebase we only have the issue remaining on the |
Unfortunately, @lcptrs, this workaround will add another problem. The result of an insert operation's inference returns the optional and required fields defined in the database. Your suggestion will make all the properties optional. I believe this problem won't be fixed in the near future. It seems to be a mix of the natural evolution of TypeScript and its config and the evolution of other dependencies. I'm not sure about that, but if the solution is to use I will probably give up and put |
is there any update on this? still not fixed. database: postgres |
same problem :( drizzle-orm: 0.36.1 |
well, that's a very tricky one, we've spent half a day with @Sukairo-02 trying to figure out what type in particular is responsible for that
|
alright, landing in |
this should be reopened as the change in |
I agree with this as Drizzle is "marketed" as a library and not a framework. On their website they say
Turning on strict mode and needing to do massive refactors to work with it, might as well be a framework for all intensive purposes. |
still facing this issue - |
It's still happening - 0.38.3 |
Hey all this is not a long term fix but made my code seem somewhat okay I just used a Partial class to make the typescript compiler relax and then also you get intellisense but careful as it won't enforce your structure on inserts.
The "strictNullChecks": true worked for me but its a lot of work if you haven't started the project with that compiler setting on. |
this issue should not be closed. it is still ongoing |
Exactly the same problem |
Still the same in 0.38.4 |
Also facing this issue with 0.39.3 |
Facing the same issue with v0.39.3. Getting this error which shows the property does exist:
Added a temporary |
Same problem here, with v0.39.3. |
@AlexBlokh sorry to ping you, but I want to manage my expectations on this one: |
This issue is so annyoing - why is it closed ?! Still happening in v.0.40.1 |
The issue still persists. |
Still happening in v.0.41.0 |
Published experimental fix in |
Working for me with {
"compilerOptions": {
/* Base Options: */
"esModuleInterop": true,
"skipLibCheck": true,
"target": "es2022",
"allowJs": true,
"resolveJsonModule": true,
"moduleDetection": "force",
"isolatedModules": true,
"strictNullChecks": false,
/* Strictness */
"strict": true,
"checkJs": true,
/* Bundled projects */
"lib": ["dom", "dom.iterable", "ES2022"],
"noEmit": true,
"module": "ESNext",
"moduleResolution": "Bundler",
"jsx": "preserve",
"plugins": [{ "name": "next" }],
"incremental": true,
/* Path Aliases */
"baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
}
},
"include": [
".eslintrc.cjs",
"next-env.d.ts",
"**/*.ts",
"**/*.tsx",
"**/*.cjs",
"**/*.js",
".next/types/**/*.ts",
"src/styles/global.css"
],
"exclude": [
"node_modules/*",
".next",
"out",
"build",
"dist",
"supabase"
]
} import { pgTable, serial, text, timestamp, integer, boolean, uniqueIndex, unique } from "drizzle-orm/pg-core";
import { relations } from "drizzle-orm";
import { InferInsertModel, InferSelectModel } from "drizzle-orm";
// Users table
export const users = pgTable('users', {
id: serial('id').primaryKey(),
name: text('name').notNull(),
username: text('username').notNull(),
email: text('email').notNull(),
profileImage: text('profile_image'),
bio: text('bio'),
isVerified: boolean('is_verified').default(false),
createdAt: timestamp('created_at').defaultNow().notNull(),
updatedAt: timestamp('updated_at').defaultNow().notNull(),
}, (table) => {
return {
usernameIdx: uniqueIndex('username_idx').on(table.username),
emailIdx: uniqueIndex('email_idx').on(table.email),
};
});
// Tweets table
export const tweets = pgTable('tweets', {
id: serial('id').primaryKey(),
content: text('content').notNull(),
userId: integer('user_id').notNull().references(() => users.id, { onDelete: 'cascade' }),
image: text('image'),
likes: integer('likes').default(0),
retweets: integer('retweets').default(0),
replies: integer('replies').default(0),
createdAt: timestamp('created_at').defaultNow().notNull(),
updatedAt: timestamp('updated_at').defaultNow().notNull(),
});
// Likes table - junction between users and tweets
export const likes = pgTable('likes', {
id: serial('id').primaryKey(),
userId: integer('user_id').notNull().references(() => users.id, { onDelete: 'cascade' }),
tweetId: integer('tweet_id').notNull().references(() => tweets.id, { onDelete: 'cascade' }),
createdAt: timestamp('created_at').defaultNow().notNull(),
}, (table) => {
return {
userTweetIdx: unique().on(table.userId, table.tweetId)
};
});
// Follows table - for following relationships
export const follows = pgTable('follows', {
id: serial('id').primaryKey(),
followerId: integer('follower_id').notNull().references(() => users.id, { onDelete: 'cascade' }),
followingId: integer('following_id').notNull().references(() => users.id, { onDelete: 'cascade' }),
createdAt: timestamp('created_at').defaultNow().notNull(),
}, (table) => {
return {
followerFollowingIdx: unique().on(table.followerId, table.followingId)
};
});
// Trends table - for trending topics
export const trends = pgTable('trends', {
id: serial('id').primaryKey(),
title: text('title').notNull(),
category: text('category').notNull(),
tweetCount: integer('tweet_count').default(0),
createdAt: timestamp('created_at').defaultNow().notNull(),
updatedAt: timestamp('updated_at').defaultNow().notNull(),
});
// Define relations
export const usersRelations = relations(users, ({ many }) => ({
tweets: many(tweets),
likes: many(likes),
followedBy: many(follows, { relationName: "followedBy" }),
following: many(follows, { relationName: "following" }),
}));
export const tweetsRelations = relations(tweets, ({ one, many }) => ({
author: one(users, {
fields: [tweets.userId],
references: [users.id],
}),
likes: many(likes),
}));
export const likesRelations = relations(likes, ({ one }) => ({
user: one(users, {
fields: [likes.userId],
references: [users.id],
}),
tweet: one(tweets, {
fields: [likes.tweetId],
references: [tweets.id],
}),
}));
export const followsRelations = relations(follows, ({ one }) => ({
follower: one(users, {
fields: [follows.followerId],
references: [users.id],
relationName: "following",
}),
following: one(users, {
fields: [follows.followingId],
references: [users.id],
relationName: "followedBy",
}),
}));
// Type definitions for easier use with API routes
export type User = InferSelectModel<typeof users>;
export type NewUser = InferInsertModel<typeof users>;
export type Tweet = InferSelectModel<typeof tweets>;
export type NewTweet = InferInsertModel<typeof tweets>;
export type Like = InferSelectModel<typeof likes>;
export type NewLike = InferInsertModel<typeof likes>;
export type Follow = InferSelectModel<typeof follows>;
export type NewFollow = InferInsertModel<typeof follows>;
export type Trend = InferSelectModel<typeof trends>;
export type NewTrend = InferInsertModel<typeof trends>; import { NextResponse } from "next/server";
import { db } from "@/db";
import { trends, NewTrend } from "@/db/schema";
import { desc } from "drizzle-orm";
export async function GET() {
try {
const allTrends = await db.select().from(trends).orderBy(desc(trends.tweetCount));
return NextResponse.json(allTrends);
} catch (error) {
console.error("Error fetching trends:", error);
return NextResponse.json(
{ error: "Failed to fetch trends" },
{ status: 500 }
);
}
}
export async function POST(request: Request) {
try {
const body = await request.json();
const { title, category, tweetCount } = body;
if (!title || !category) {
return NextResponse.json(
{ error: "Title and category are required" },
{ status: 400 }
);
}
const newTrend: NewTrend = {
title,
category,
tweetCount: tweetCount || 0,
};
const insertedTrend = await db.insert(trends).values(newTrend).returning();
return NextResponse.json(insertedTrend[0]);
} catch (error) {
console.error("Error creating trend:", error);
return NextResponse.json(
{ error: "Failed to create trend" },
{ status: 500 }
);
}
} |
That's great to hear. I went the other way and turned in strict mode and worked through the 1000 errors from the rest of my codebase 🤣 |
I have not had a chance to look at this issue since last year, but I definitely think changing tsconfig or expecting user to alter their tsconfig is not (should not) be the solution. |
@DavidHavl that's exactly what we've done, we don't expect developers to change config, we want to provide as much of an out of the box as possible, when it comes to types and we just need feedback from developers who've had issues, thanks |
@AlexBlokh Oh I see, that is excellent! |
* Add support for cross join (#1669) * Add cross join support * Add cross join tests * Updated docs links (docs TBD) * Merged cross join function types into join function types, fixed missing cases for `cross` join type, ordered `crossJoin` test queries * `onIndex` support for `MySQL` `crossJoin`, fixed lack of `onIndex` param description in JSDoc, additional tests, disabled test case failing due to driver's issue --------- Co-authored-by: Sukairo-02 <[email protected]> * Export `PgTextBuilderInitial` type (#1286) * MySQL: Removed .fullJoin() from MySQL Api (#1351) Added new type MySqlJoinType which excludes the option for full joins and is used in the MySQL query builder createJoin function instead of the regular JoinType. Also removed two MySQL select type-tests which included the fullJoin function Co-authored-by: Sukairo-02 <[email protected]> * [Pg] Add support for left and inner lateral join in postgres (#1079) * feat: added support for left and inner lateral join in postgres Signed-off-by: Alex Vukadinov <[email protected]> * chore: updated method descriptions on the new joins Signed-off-by: Alex Vukadinov <[email protected]> * GH-420 allowing sql inside lateral joins and revert package.json * GH-420 reverted package.json empty line at the end * Changed JSDoc [WIP], reversed check --------- Signed-off-by: Alex Vukadinov <[email protected]> Co-authored-by: Sukairo-02 <[email protected]> * Completed `left`, `inner`, `cross` lateral joins in `postgresql`, `mysql`, `gel`, `singlestore`, disabled implicit `schema.table` prefixes in column selections on single table selections for `gel` due to possible errors in subqueries on column name matches in inner and outer queries, added\altered related tests * [SingleStore] Add Connection Attributes and Fix Options (#4417) * add connection attributes to SingleStore driver connection * fix allowing connection strings/options rather than external pool --------- Co-authored-by: Andrii Sherman <[email protected]> * Fix for #2654, related tests (#4353) * Dprint * Bumped version, added changelog, fixed broken test case * fix(3554) Correct spelling of `nowait` flag (#3555) * Fixed `nowait` in `Gel`, `SingleStore`, added change to changelog * Updated changelog * Fixed broken test case * Fixed `nowait` tests in `bun-sql`, `mysql-prefixed` * Add changelog updates --------- Signed-off-by: Alex Vukadinov <[email protected]> Co-authored-by: L-Mario564 <[email protected]> Co-authored-by: Dan Imhoff <[email protected]> Co-authored-by: Itay Ben-Ami <[email protected]> Co-authored-by: Alex Vukadinov <[email protected]> Co-authored-by: Mitchell Adair <[email protected]> Co-authored-by: Andrii Sherman <[email protected]> Co-authored-by: Jacob Elder <[email protected]>
Should be fixed in |
What version of
drizzle-orm
are you using?0.32.0
What version of
drizzle-kit
are you using?0.23.0
Describe the Bug
I've encountered a TypeScript error when trying to update an optional field using the set method. The error occurs only for optional fields, while required fields work as expected.
Steps to reproduce:
Expected behavior:
The update operation should work without any TypeScript errors, as all fields being updated are defined in the table schema.
Actual behavior:
TypeScript throws an error for the optional 'description' field:
"Object literal may only specify known properties, and 'description' does not exist in type"
The error does not occur for the required 'title' field.
Additional notes:
as any
type assertion works as a temporary workaround, but it's not a proper solutionPlease let me know if you need any additional information or clarification to investigate this issue.
Expected behavior
The update operation should work without any TypeScript errors, as all fields being updated are defined in the table schema.
Environment & setup
Database: SQLite
Node: 20
Typescript: 5.3.3
The text was updated successfully, but these errors were encountered: