Forward global props to dotnet run #47694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
mariam-abdulla
requested review from
Youssef1313
and removed request for
a team and
Copilot
Youssef1313
approved these changes
Mar 18, 2025
mariam-abdulla
deleted the
dev/mabdullah/forward-global-props-to-dotnet-run-in-dotnet-test
branch
This was referenced Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
src/Cli/dotnet/commands/dotnet-testdirectory, focusing on code simplification and cleanup. The most important changes include removing an unused import, refactoring a method to use a more concise syntax, and updating the way MSBuild arguments are appended.Code simplification and cleanup:
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs: Removed the unused import statement forNuGet.Packaging.src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs: Refactored theGetSolutionFilePathsmethod to use a more concise array initialization syntax.src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Updated theBuildArgsWithDotnetRunmethod to append MSBuild arguments using a loop instead of individually checking and appending architecture and configuration options.Relates to #45927
Fixes #47635
Fixes #47614