Skip to content

BuildArgsWithDotnetRun doesn't forward global properties #47614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Youssef1313 opened this issue Mar 14, 2025 · 0 comments · Fixed by #47694
Closed

BuildArgsWithDotnetRun doesn't forward global properties #47614

Youssef1313 opened this issue Mar 14, 2025 · 0 comments · Fixed by #47694
Assignees
Milestone

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Mar 14, 2025

private string BuildArgsWithDotnetRun(TestOptions testOptions)
{
StringBuilder builder = new();
builder.Append($"{CliConstants.DotnetRunCommand} {TestingPlatformOptions.ProjectOption.Name} \"{_module.ProjectFullPath}\"");
// Because we restored and built before in MSHandler, we will skip those with dotnet run
builder.Append($" {CommonOptions.NoRestoreOption.Name}");
builder.Append($" {TestingPlatformOptions.NoBuildOption.Name}");
if (!string.IsNullOrEmpty(testOptions.Architecture))
{
builder.Append($" {CommonOptions.ArchitectureOption.Name} {testOptions.Architecture}");
}
if (!string.IsNullOrEmpty(testOptions.Configuration))
{
builder.Append($" {TestingPlatformOptions.ConfigurationOption.Name} {testOptions.Configuration}");
}
if (!string.IsNullOrEmpty(_module.TargetFramework))
{
builder.Append($" {CliConstants.FrameworkOptionKey} {_module.TargetFramework}");
}
builder.Append($" {CliConstants.ParametersSeparator} ");
AppendCommonArgs(builder, testOptions);
return builder.ToString();
}

FYI @mariam-abdulla

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Mar 14, 2025
@Youssef1313 Youssef1313 added Area-dotnet test and removed Area-Infrastructure untriaged Request triage from a team member labels Mar 14, 2025
@Youssef1313 Youssef1313 added this to the 10.0.1xx milestone Mar 14, 2025
@mariam-abdulla mariam-abdulla self-assigned this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants