Skip to content

Backport of auditSources fix #42826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Winniexu01
Copy link
Member

Backport of #42740

release/9.0.1xx-rc1 branch does not have the fix for dotnet/source-build#4548.

Nuget.client introduced source auditing with #42658, see NuGet/NuGet.Client#5939

This breaks source build, offline legs, as we do not use any online sources in those scenarios, and do not have internet access.

@ViktorHofer
Copy link
Member

Duplicate of #42800

@ViktorHofer ViktorHofer marked this as a duplicate of #42800 Aug 19, 2024
@ViktorHofer ViktorHofer marked this as not a duplicate of #42800 Aug 19, 2024
@ViktorHofer ViktorHofer reopened this Aug 19, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) August 19, 2024 09:50
@ViktorHofer ViktorHofer merged commit 5e9a32e into dotnet:release/9.0.1xx-rc1 Aug 19, 2024
31 checks passed
@NikolaMilosavljevic
Copy link
Member

We also need #42800 for release/9.0.1xx. PR was failing some unrelated checks - I've updated it with latest in branch - hopefully it fixes it.

Alternatively - rc1 branch would flow the change from this PR...

@Winniexu01 Winniexu01 deleted the 901RC-nugetaduitsourcefix branch August 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants