Skip to content

Backport of auditSources fix #42800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NikolaMilosavljevic
Copy link
Member

Backport of #42740

release/9.0.1xx branch does not have the fix for dotnet/source-build#4548. See dotnet/source-build#4558

Nuget.client introduced source auditing with #42658, see NuGet/NuGet.Client#5939

This breaks source build, offline legs, as we do not use any online sources in those scenarios, and do not have internet access.

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 19, 2024

I think this PR can now be closed as #42826 already got merged into RC1 and sdk has a inner branch port bot.

@NikolaMilosavljevic
Copy link
Member Author

I think this PR can now be closed as #42826 already got merged into RC1 and sdk has a inner branch port bot.

Yeah - I was just commenting on the other PR. Change in rc1 would flow up.

@ellahathaway
Copy link
Member

ellahathaway commented Aug 21, 2024

This change still hasn't flowed to 9.0. Do have a general timeframe for when we can expect a flow?

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 21, 2024

This change still hasn't flowed to 9.0. Do have a general timeframe for when we can expect a flow?

@marcpopMSFT do rc1 changes not flow into 9.0.1xx via the merge bot?

@marcpopMSFT
Copy link
Member

Changes in the SDK repo do not automatically flow from the preview/rc branches into the mainline branches. Any change made directly to the rc1 branch will need to be backported out so this PR is still required.

@NikolaMilosavljevic
Copy link
Member Author

@ViktorHofer @ellahathaway @marcpopMSFT we need a review of this PR before it can be merged.

@NikolaMilosavljevic NikolaMilosavljevic merged commit c40158a into dotnet:release/9.0.1xx Aug 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants