-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Allow Razor cohosting to hook into configuration change notifications #78364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Microsoft.CodeAnalysis.LanguageServer.Handler; | ||
|
||
namespace Microsoft.CodeAnalysis.LanguageServer; | ||
|
||
internal interface IOnConfigurationChanged | ||
{ | ||
Task OnConfigurationChangedAsync(RequestContext context, CancellationToken cancellationToken); | ||
} |
13 changes: 13 additions & 0 deletions
13
src/Tools/ExternalAccess/Razor/Features/Cohost/ICohostConfigurationChangedService.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Threading; | ||
using System.Threading.Tasks; | ||
|
||
namespace Microsoft.CodeAnalysis.ExternalAccess.Razor.Cohost; | ||
|
||
internal interface ICohostConfigurationChangedService | ||
{ | ||
Task OnConfigurationChangedAsync(RazorCohostRequestContext requestContext, CancellationToken cancellationToken); | ||
} |
46 changes: 46 additions & 0 deletions
46
src/Tools/ExternalAccess/Razor/Features/Cohost/RazorConfigurationChangedServiceFactory.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using System.Composition; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Microsoft.CodeAnalysis.Host.Mef; | ||
using Microsoft.CodeAnalysis.LanguageServer; | ||
using Microsoft.CodeAnalysis.LanguageServer.Handler; | ||
|
||
namespace Microsoft.CodeAnalysis.ExternalAccess.Razor.Cohost; | ||
|
||
[ExportCSharpVisualBasicLspServiceFactory(typeof(RazorConfigurationChangedService)), Shared] | ||
[method: ImportingConstructor] | ||
[method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
internal sealed class RazorConfigurationChangedServiceFactory( | ||
[Import(AllowDefault = true)] Lazy<ICohostConfigurationChangedService>? cohostConfigurationChangedService) : ILspServiceFactory | ||
{ | ||
public ILspService CreateILspService(LspServices lspServices, WellKnownLspServerKinds serverKind) | ||
{ | ||
return new RazorConfigurationChangedService(cohostConfigurationChangedService); | ||
} | ||
|
||
private class RazorConfigurationChangedService( | ||
Lazy<ICohostConfigurationChangedService>? cohostConfigurationChangedService) : ILspService, IOnConfigurationChanged | ||
{ | ||
public Task OnConfigurationChangedAsync(RequestContext context, CancellationToken cancellationToken) | ||
{ | ||
if (context.ServerKind is not (WellKnownLspServerKinds.AlwaysActiveVSLspServer or WellKnownLspServerKinds.CSharpVisualBasicLspServer)) | ||
{ | ||
return Task.CompletedTask; | ||
} | ||
|
||
if (cohostConfigurationChangedService is null) | ||
{ | ||
return Task.CompletedTask; | ||
} | ||
|
||
using var languageScope = context.Logger.CreateLanguageContext(Constants.RazorLanguageName); | ||
var requestContext = new RazorCohostRequestContext(context); | ||
return cohostConfigurationChangedService.Value.OnConfigurationChangedAsync(requestContext, cancellationToken); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be teaching me something here. When exporting via the factory, does the service get registered for each of the interfaces that it implements? Or does something else tie this to IOnConfigurationChanged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but its not specific to factories. The magic is here I believe:
roslyn/src/LanguageServer/Protocol/LspServices/AbstractExportLspServiceAttribute.cs
Line 75 in 624361d
roslyn/src/LanguageServer/Protocol/LspServices/LspServices.cs
Line 210 in 624361d