Allow Razor cohosting to hook into configuration change notifications #78364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
JoeRobich
reviewed
Apr 29, 2025
| { | ||
| public ILspService CreateILspService(LspServices lspServices, WellKnownLspServerKinds serverKind) | ||
| { | ||
| return new RazorConfigurationChangedService(cohostConfigurationChangedService); |
There was a problem hiding this comment.
You might be teaching me something here. When exporting via the factory, does the service get registered for each of the interfaces that it implements? Or does something else tie this to IOnConfigurationChanged?
There was a problem hiding this comment.
Yes, but its not specific to factories. The magic is here I believe:
DustinCampbell
approved these changes
Apr 29, 2025
dibarbet
approved these changes
Apr 29, 2025
src/Tools/ExternalAccess/Razor/Features/Cohost/RazorConfigurationChangedServiceFactory.cs
Outdated
Show resolved
Hide resolved
…ionChangedServiceFactory.cs Co-authored-by: David Barbet <[email protected]>
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
May 2, 2025
#11800) Part of #11759 This cleans up `IClientSettingsManager` and puts it back to its previous state, removing `IClientSettingsReader` at the same time, and also implements a hook for VS Code to get notified when the VS Code configuration changes, and to read the settings as appropriate. Needs a bump to dotnet/roslyn#78364 before it will build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Roslyn uses dynamic registration for configuration change requests, Razor can't. Even if we could, as a document-less request, it couldn't be routed to us anyway. So this exposes a hook for us through our EA.
Razor side is at dotnet/razor#11800
Part of dotnet/razor#11759