Skip to content

[vs17.2] Customize opt-in for CG step #8695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Apr 24, 2023

Context

Explict call to ComponentGovernanceComponentDetection@0 task (via /eng/common/templates/steps/component-governance.yml template) based on the branch name (so that this can be invoked for 'vs*' branches as well)

Note

This will be breaking until we consume this arcade update: dotnet/arcade@b1a9b86, it's now flowing to MSBuild main in this PR: #8658

Testing the changes on: https://github.com/dotnet/msbuild/tree/vs-test-only
ADO run: (vs* branch, the CG step injected) https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7672204&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=424211a8-7b86-5e93-500e-ae39b50be1a7

Blocked by

#8697
#8302

@ghost
Copy link

ghost commented Apr 24, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@JanKrivanek JanKrivanek added Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. do-not-merge labels Apr 24, 2023
Copy link
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm assuming it would be syntactically incorrect to split the 'if' across multiple lines with indentations, correct? Just wondering because it's a bit hard to parse the dis/conjunctions 🙂

@JanKrivanek
Copy link
Member Author

LGTM! I'm assuming it would be syntactically incorrect to split the 'if' across multiple lines with indentations, correct? Just wondering because it's a bit hard to parse the dis/conjunctions 🙂

Yeah - syntactic meaning of indention and whitespaces is comming into way. There might be a way - I just didn't find any example in whole arcade and wasn't able to quickly invent something myself.

For reference:

@JanKrivanek JanKrivanek added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 28, 2023
@Forgind Forgind merged commit 32ef3ee into dotnet:vs17.2 May 1, 2023
@JanKrivanek JanKrivanek deleted the infra/cg-vs17-2 branch May 2, 2023 11:09
@JanKrivanek
Copy link
Member Author

JanKrivanek commented May 2, 2023

This needs update of arcade to 6.0.0-beta.23221.7

triggering:

darc trigger-subscriptions --id 8601dd62-c366-4971-a65d-08dabd10ae64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants