-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[vs17.2] Customize opt-in for CG step #8695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
40c0979
to
a88456e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm assuming it would be syntactically incorrect to split the 'if' across multiple lines with indentations, correct? Just wondering because it's a bit hard to parse the dis/conjunctions 🙂
d5ea2ce
to
a88456e
Compare
Yeah - syntactic meaning of indention and whitespaces is comming into way. There might be a way - I just didn't find any example in whole arcade and wasn't able to quickly invent something myself. For reference:
|
This needs update of arcade to triggering:
|
Context
Explict call to
ComponentGovernanceComponentDetection@0
task (via/eng/common/templates/steps/component-governance.yml
template) based on the branch name (so that this can be invoked for 'vs*' branches as well)Note
This will be breaking until we consume this arcade update: dotnet/arcade@b1a9b86, it's now flowing to MSBuild main in this PR: #8658
Testing the changes on: https://github.com/dotnet/msbuild/tree/vs-test-only
ADO run: (vs* branch, the CG step injected) https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7672204&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=424211a8-7b86-5e93-500e-ae39b50be1a7
Blocked by
#8697
#8302