Make parameters filter more strict #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| module Doorkeeper | |||
| class Engine < Rails::Engine | |||
| initializer "doorkeeper.params.filter" do |app| | |||
| app.config.filter_parameters += [:client_secret, :code, :token] | |||
| app.config.filter_parameters << /^(client_secret|code|authentication_token|access_token|refresh_token)$/ | |||
There was a problem hiding this comment.
Suggested rewrite:
parameters = %w(client_secret code authentication_token access_token refresh_token)
app.config.filter_parameters << /^(#{Regexp.union parameters})$/
|
Thank you, @Tensho! Can you please:
Then I'll merge this in. Thank you very much! :) |
Tensho
force-pushed
the
strict-match-filter-parameters
branch
from
b19e517 to
29b1693
Compare
| @@ -1,7 +1,8 @@ | |||
| module Doorkeeper | |||
| class Engine < Rails::Engine | |||
| initializer "doorkeeper.params.filter" do |app| | |||
| app.config.filter_parameters += [:client_secret, :code, :token] | |||
| parameters = %w(client_secret code authentication_token access_token refresh_token) | |||
|
Thank you! |
rhryniow
pushed a commit
to Ipsos-Tivian/tivian-cxi-doorkeeper
that referenced
this pull request
Mar 12, 2025
…-parameters Make parameters filter more strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#810
#792
rails/rails#24346