Skip to content

Make filter parameters regexp more strict #810

Closed
@Tensho

Description

@Tensho

Doorkeeper's engine initializes [:client_secret, :code, :token] filter parameters and they are compiled further to /client_secret|code|secret|password/ regexp inside ParameterFilter module (password is Rails default). That means application specific parameters, like postcode, codebase, tokenization, etc., will be filtered out.

What do you think if symbols will be replaced with word boundaries regexp like
/^(client_secret|code|authentication_token|refresh_token)$/ and others? Sorry, I'm not aware of all possible parameters in use.

Also I've described this problem in rails issue with more details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions