Reuse the existing token in client_credentials flow #736
Conversation
| @@ -1,6 +1,12 @@ | |||
| require 'spec_helper_integration' | |||
|
|
|||
| module Doorkeeper::OAuth | |||
| describe ClientCredentialsRequest do | |||
| subject do | |||
| # TODO Do we need something here too? | |||
There was a problem hiding this comment.
Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
jimmykarily
force-pushed
the
fix_issue_661
branch
from
ddfd52f to
5a10e9b
Compare
| @@ -1,6 +1,12 @@ | |||
| require 'spec_helper_integration' | |||
|
|
|||
| module Doorkeeper::OAuth | |||
| describe ClientCredentialsRequest do | |||
| subject do | |||
| # TODO: Do we need something here too? | |||
There was a problem hiding this comment.
I don't know if there are any testing conventions on the project regarding "side" checking. This file and spec/lib/oauth/client_credentials_request_spec.rb seem relevant although they would test the same thing as on the file above. Should I keep only the above test?
There was a problem hiding this comment.
I don't think we need to add this indeed, would you remove this new block please?
|
Left two comments, thank you! Can you please rebase on top of latest master when you address them? Thank you! |
|
Also, please add a note to NEWS.md file. Thank you! 😃 👏 |
jimmykarily
force-pushed
the
fix_issue_661
branch
from
5a10e9b to
90fbeee
Compare
Fixes issue 661: doorkeeper-gem#661
jimmykarily
force-pushed
the
fix_issue_661
branch
from
90fbeee to
4d6b8f0
Compare
|
Rebased, fixed comments and added entry in NEWS.md (I amended the commit since the changes were pretty clear). @tute thanks. |
Reuse the existing token in client_credentials flow
|
Thanks so much! |
Reuse the existing token in client_credentials flow
Fixes issue 661: #661