Reuse access tokens for the client_credentials grant type

[gilbertquri]

Doorkeeper does not seem to reuse access tokens for the client_credentials grant type in any case. Is this intentional?

[tute]

This sounds like a bug, not intentional for sure.

[vovimayhem]

I think I read somewhere in this Issue Tracker and in the RFC specs that client credential tokens should not be allowed to refresh... I could be remembering it wrong, but let's validate if that's true first.

[tute]

I think I read somewhere in this Issue Tracker and in the RFC specs that client credential tokens should not be allowed to refresh... I could be remembering it wrong, but let's validate if that's true first.

Please let us know where did you read this @vovimayhem, or the reasons behind that assertion that you remember. Thank you!

[vovimayhem]

@tute searched, but can't find it. :( I'll give it an eye in the RFC specs

[jimmykarily]

Guys any progress on this?

[jimmykarily]

@vovimayhem you probably refer to this. I don't think the original problem is a missing refresh token though. My problem is that when I request an access token for a client, even if a valid and not expired one exists, a new one is generated and returned. This is not a problem if the client can store the token and reuse it until it expires, but in my case the token is used from a short lived client (a docker container) and every time the container is launched the token generating process starts again resulting in many valid tokens for the same client. I can't find anything in the RFC that justifies this behavior. Still, I might missed it.

[jimmykarily]

I created a Pull Request with what seems to fix the issue, at least on my project. I can change the base branch to the original gem's master if you prefer to keep the conversation on this repo (I just didn't want to create a PR until it's ready).

[tute]

I created a Pull Request with what seems to fix the issue, at least on my project. I can change the base branch to the original gem's master if you prefer to keep the conversation on this repo (I just didn't want to create a PR until it's ready).

@jimmykarily that looks good to me, feel free to complete the tests and open up a PR here. Thank you!

[jimmykarily]

I will try to get it ready in the next couple of days. I remember having some trouble with the tests. I will ask for help if I get stuck.