Skip to content

Merge 4.3.x up into 5.0.x #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Nov 15, 2024
Merged

Merge 4.3.x up into 5.0.x #6606

merged 28 commits into from
Nov 15, 2024

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 15, 2024

No description provided.

simPod and others added 28 commits October 31, 2024 17:07
…octrine#6563)

|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | <!-- use #NUM format to reference an issue -->

#### Summary

Covers the concern expressed by @greg0ire
doctrine#6545 (comment)

This ensures the transaction is (not)active based on `autocommmit` mode
when interacting with `transactional()`.
… transaction

Let's get rid of There's no active transaction exception which occurs e.g. when using deferred constraints so the violation is checked at the end of the transaction and not during it.

- Do not rollback only on exceptions where we know the transaction is no longer active
- Introduce TransactionRolledBack exception
- Transform Oracle's "transaction rolled back" exception and use the underlying one that DBAL supports
Right now, the Codecov UI displays downloads in a confusing way:
You get an "appveyor" header, and then 2 list items with links to
appveyor, followed by one list item with a link to Github.

We didn't specify that appveyor name anywhere, maybe Codecov behaves
differently on that platform. Let us see if specifying names for each
system makes things clearer.
Distinguish between Appveyor and github-action
Fix incorrect `transactional()` handling when DB auto-rolled back the transaction
… transaction

Let's get rid of There's no active transaction exception which occurs e.g. when using deferred constraints so the violation is checked at the end of the transaction and not during it.

- Do not rollback only on exceptions where we know the transaction is no longer active
- Introduce TransactionRolledBack exception
- Transform Oracle's "transaction rolled back" exception and use the underlying one that DBAL supports
savepoint support is required in v4 for transaction nesting
Fix incorrect handling of transactions when using deferred constraints (v4)
Fix dropping the PK on a PostgreSQL table with quoted name
The pattern used in parseTableCommentFromSQL() was invalid. It would
wrap the value returned by quoteSingleIdentifier() in another set of
quotes. It would only work for unquoted table names, which would be
handled but the pattern that matches an unquoted name.
sp_rename accepts the old name as a qualified name but the new name as
a literal value.

The caller of the stored procedure should be able to qualify the old
name in order to reference a column in some table or a table in some
schema, etc. But it's not necessary for the new name because the
reference to the object being renamed is already established in the
old name.
Enable Windows Update service on AppVeyor
…ment

Fix parsing quoted table name on SQLite
@morozov morozov requested a review from greg0ire November 15, 2024 16:54
@morozov morozov merged commit 57fc66f into doctrine:5.0.x Nov 15, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants