Merge 2161a70e7 up into 4.2.x #6585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…octrine#6563) | Q | A |------------- | ----------- | Type | improvement | Fixed issues | <!-- use #NUM format to reference an issue --> #### Summary Covers the concern expressed by @greg0ire doctrine#6545 (comment) This ensures the transaction is (not)active based on `autocommmit` mode when interacting with `transactional()`.
Right now, the Codecov UI displays downloads in a confusing way: You get an "appveyor" header, and then 2 list items with links to appveyor, followed by one list item with a link to Github. We didn't specify that appveyor name anywhere, maybe Codecov behaves differently on that platform. Let us see if specifying names for each system makes things clearer.
Distinguish between Appveyor and github-action
|
Argh, not even this passes the build. It does pass it locally, but here in the CI, I get @simPod please help. |
|
I've already solved it in #6546, will do today/in the morning |
savepoint support is required in v4 for transaction nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't manage to merge 3.9.x up into 4.2.x, and 2161a70 is the most recent commit on 3.9.x I managed to merge up.
@simPod , can you please take care of merging 3.9.x up into 4.2.x?