history: add export command #3073
Conversation
tonistiigi
force-pushed
the
add-trace-export-command
branch
from
032bd84 to
dbcbaa0
Compare
There was a problem hiding this comment.
When exporting a build record and importing it back, the name is not the same:
I think this is because we don't check the local state for imported builds in desktop-build backend on Docker Desktop. Maybe we could set the builder and node name as annotation in the export bundle so we can look if a local state exists for this ref? WDYT?
commands/history/export.go
Outdated
| cmd := &cobra.Command{ | ||
| Use: "export [OPTIONS] [REF]", | ||
| Short: "Export a build into Docker Desktop bundle", | ||
| Args: cobra.MaximumNArgs(1), |
There was a problem hiding this comment.
If we want feature parity with export-build tool, I think we should allow multiple refs to be exported. This is needed for GHA case when exporting bake builds.
Also the export-build exports all records for the builder being used if no refs are set but I think to be consistent with other history commands this is fine to export the first one. So maybe we could have an --all flag for such case?
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "export [OPTIONS] [REF]", | ||
| Short: "Export a build into Docker Desktop bundle", |
There was a problem hiding this comment.
Not sure if "Docker Desktop" should be stipulated here. I think the following is enough:
| Short: "Export a build into Docker Desktop bundle", | |
| Short: "Export build records", |
or
| Short: "Export a build into Docker Desktop bundle", | |
| Short: "Export build records bundle", |
There was a problem hiding this comment.
Also there are some places where we talk about build and other build record. I think we should be consistent:
buildx/commands/history/import.go
Line 123 in 18ccba0
Import build records into Docker Desktop
buildx/commands/history/logs.go
Line 101 in 18ccba0
Print the logs of a build record
buildx/commands/history/open.go
Line 60 in 18ccba0
Open a build record in Docker Desktop
There was a problem hiding this comment.
Not sure if "Docker Desktop" should be stipulated here. I think the following is enough:
It kind of shows what you can do with the bundle file.
|
Added support for |
tonistiigi
force-pushed
the
add-trace-export-command
branch
from
e341cbc to
37dc0f0
Compare
Allow builds to be exported into .dockerbuild bundles that can be shared and imported into Docker Desktop. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
add-trace-export-command
branch
4 times, most recently
from
367fc9c to
3e56b2e
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
add-trace-export-command
branch
from
3e56b2e to
45dfb84
Compare
There was a problem hiding this comment.
Merging this one.
We need a follow-up for consistency in command descriptions related to #3073 (comment)
I will open an issue to track work that needs to be done on GHA to use this command instead of export-build tool.
And also needs documentation for all history commands and probably new manual in https://docs.docker.com/build/? Can someone from your team take care of it @usha-mandya?
part of #2711
Allow builds to be exported into .dockerbuild bundles that can be shared and imported into Docker Desktop.