Fix attest extra arguments #3027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
from
664d5e7 to
5e9f0ad
Compare
Hum indeed, I forgot the extra arguments support which has been introduced in moby/buildkit#5372. I think we also need docs changes: |
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
from
b570e26 to
3db226c
Compare
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
from
3db226c to
89713e4
Compare
Signed-off-by: Laurent Goderre <[email protected]>
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
from
89713e4 to
9b2e0c7
Compare
tonistiigi
reviewed
Feb 28, 2025
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
2 times, most recently
from
24c1e37 to
630c42a
Compare
tonistiigi
approved these changes
Feb 28, 2025
tonistiigi
reviewed
Feb 28, 2025
| writer := csv.NewWriter(&attr) | ||
| writer.Write([]string{pair}) | ||
| writer.Flush() | ||
| pair = strings.TrimSpace(attr.String()) |
There was a problem hiding this comment.
You may add a comment in here that csv writer adds a newline. Not entirely obvious.
Signed-off-by: Laurent Goderre <[email protected]>
LaurentGoderre
force-pushed
the
fix-attest-extra-args
branch
from
630c42a to
b06bddf
Compare
tonistiigi
approved these changes
Feb 28, 2025
crazy-max
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parsing of attest argument broke support for extra args for the attest command in buildkit as shown with these tests:
https://github.com/moby/buildkit/blob/master/frontend/attestations/parse_test.go#L31-L58
Note that the case should preserved for these args as well as they are set as env var in the scanner.