Skip to content

Commit 9b2e0c7

Browse files
Fix handling of attest extra arguments
Signed-off-by: Laurent Goderre <[email protected]>
1 parent 4e91fe6 commit 9b2e0c7

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

util/buildflags/attests.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ func (a *Attest) UnmarshalText(text []byte) error {
148148
if !ok {
149149
return errors.Errorf("invalid value %s", field)
150150
}
151-
key = strings.TrimSpace(strings.ToLower(key))
151+
keyLower := strings.TrimSpace(strings.ToLower(key))
152152

153-
switch key {
153+
switch keyLower {
154154
case "type":
155155
a.Type = value
156156
case "disabled":
@@ -159,6 +159,8 @@ func (a *Attest) UnmarshalText(text []byte) error {
159159
return errors.Wrapf(err, "invalid value %s", field)
160160
}
161161
a.Disabled = disabled
162+
case "generator":
163+
a.Attrs[keyLower] = value
162164
default:
163165
a.Attrs[key] = value
164166
}

util/buildflags/export.go

+11-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package buildflags
22

33
import (
4+
"encoding/csv"
45
"encoding/json"
56
"maps"
67
"regexp"
@@ -259,9 +260,16 @@ func (w *csvBuilder) Write(key, value string) {
259260
if w.sb.Len() > 0 {
260261
w.sb.WriteByte(',')
261262
}
262-
w.sb.WriteString(key)
263-
w.sb.WriteByte('=')
264-
w.sb.WriteString(value)
263+
264+
var attr strings.Builder
265+
writer := csv.NewWriter(&attr)
266+
267+
writer.Write([]string{
268+
key + "=" + value,
269+
})
270+
writer.Flush()
271+
272+
w.sb.WriteString(strings.TrimSpace(attr.String()))
265273
}
266274

267275
func (w *csvBuilder) WriteAttributes(attrs map[string]string) {

0 commit comments

Comments
 (0)