csi: use publish_info for storing and accessing the volume name #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does away with the need for the nodes to call the API to fetch the volume name, when it can be stored in the Status.AttachmentMetadata of the VolumeAttachment object.
|
This looks good @joonas. Seems like I totally forgot that the response has something like this. There are couple of improvements we can make, such as using |
davidhalter
pushed a commit
to cloudscale-ch/csi-cloudscale
that referenced
this pull request
Nov 15, 2018
This used to be the commit message below from digitalocean/csi-digitalocean#99: csi: use publish_info for storing and accessing the volume name This does away with the need for the nodes to call the API to fetch the volume name, when it can be stored in the Status.AttachmentMetadata of the VolumeAttachment object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After tracing through a bunch of the CSI code, I came to the conclusion that this could be a viable strategy for doing away with the need for the nodes to call the API to fetch the volume name.
Super open to feedback here, I've verified that this does indeed work by running the integration test suite against a cluster with my custom build deployed on it for CSI.