feat: Read log signal from DB

master/internal/api_experiment.go

@@ -2706,6 +2706,7 @@ func (a *apiServer) SearchExperiments(
 		Column("searcher_metric_value").
 		Column("trials.external_trial_id").
 		ColumnExpr("nullif(trials.metadata, 'null') as metadata").
+		ColumnExpr("NULL as log_signal").
 		Join("LEFT JOIN validations bv ON trials.best_validation_id = bv.id").
 		Join("LEFT JOIN validations lv ON trials.latest_validation_id = lv.id").
 		Join("LEFT JOIN checkpoints_v2 new_ckpt ON new_ckpt.id = trials.warm_start_checkpoint_id").

master/internal/api_runs.go

@@ -170,6 +170,7 @@ func getRunsColumns(q *bun.SelectQuery) *bun.SelectQuery {
 			'pachyderm_integration', NULLIF(e.config#>'{integrations,pachyderm}', 'null'),
 			'id', e.id) AS experiment`).
 		ColumnExpr("rm.metadata AS metadata").
+		ColumnExpr("r.log_signal AS log_signal").
 		Join("LEFT JOIN experiments AS e ON r.experiment_id=e.id").
 		Join("LEFT JOIN runs_metadata AS rm ON r.id=rm.run_id").
 		Join("LEFT JOIN users u ON e.owner_id = u.id").

master/internal/run/postgres_run_intg_test.go

@@ -29,7 +29,7 @@ func TestMigrateTrials(t *testing.T) {
 		}
 		// get all trial info, excluding additional fields added after the transition to runs.
 		require.NoError(t, db.Bun().NewSelect().Table("trials").
-			ColumnExpr("to_jsonb(trials.*)-'metadata' AS trial_data").
+			ColumnExpr("to_jsonb(trials.*)-'metadata'-'log_signal' AS trial_data").
 			Order("id").
 			Scan(ctx, &currentTrialsViewData),
 		)

master/static/migrations/20240918161807_add-log-signal.tx.up.sql

@@ -0,0 +1,3 @@
+ALTER table public.runs
+    ADD COLUMN log_signal text;
+

master/static/srv/proto_get_trials_plus.sql

@@ -113,6 +113,7 @@ SELECT
   t.start_time,
   t.end_time,
   t.hparams,
+  t.log_signal,
   new_ckpt.uuid AS warm_start_checkpoint_uuid,
   (
     SELECT tt.task_id FROM run_id_task_id tt

master/static/views_and_triggers/up/metrics.sql

@@ -24,6 +24,7 @@ CREATE VIEW trials AS
     r.experiment_id,
     r.warm_start_checkpoint_id,
     r.runner_state,
+    r.log_signal,
     rm.metadata AS metadata
    FROM trials_v2 t
      JOIN runs r ON t.run_id = r.id