-
Notifications
You must be signed in to change notification settings - Fork 365
feat: Read log signal from DB #9959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9959 +/- ##
==========================================
- Coverage 54.53% 54.53% -0.01%
==========================================
Files 1257 1257
Lines 156933 156956 +23
Branches 3614 3614
==========================================
+ Hits 85587 85593 +6
- Misses 71213 71230 +17
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
594f22d
to
d32f35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some test cases? Also could you check the performance dashboard to make sure that sql script changes do not cause a regression before merging? Everything else looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Nice work!
@salonig23 Thanks for your feedbacks! As discussed offline, we plan to add test cases to the "write" side of log signal. Also I do see a increase of query time at the perf dashboard, but I doubt that's related to the changes from this PR.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added few comments, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work and thanks for looking into the perf dashboard
Ticket
MD-495 MD-496
Description
Updates the

/api/v1/runs
and/api/v1/trials/{id}
to return the log signal.Display the log signal at run details page
Display of the log signal at runs table.

This PR uses the same DB migration as the one from this PR
Test Plan
Update DB, set
tasks -> log_signal
to values likeCUDA OOM
, at the run details page, there should be a badge that displays the log signal.Checklist
docs/release-notes/
See Release Note for details.