Skip to content

feat: Read log signal from DB #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2024
Merged

feat: Read log signal from DB #9959

merged 13 commits into from
Sep 25, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Sep 18, 2024

Ticket

MD-495 MD-496

Description

Updates the /api/v1/runs and /api/v1/trials/{id} to return the log signal.
Display the log signal at run details page
Screenshot 2024-09-23 at 7 53 47 PM

Display of the log signal at runs table.
Screenshot 2024-09-23 at 10 52 28 AM

This PR uses the same DB migration as the one from this PR

Test Plan

Update DB, set tasks -> log_signal to values like CUDA OOM, at the run details page, there should be a badge that displays the log signal.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit cb49904
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66f4466067388e0008cae771
😎 Deploy Preview https://deploy-preview-9959--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (bc3b2a6) to head (cb49904).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../src/pages/TrialDetails/Header/TrialHeaderLeft.tsx 41.17% 10 Missing ⚠️
webui/react/src/pages/FlatRuns/columns.ts 0.00% 1 Missing ⚠️
webui/react/src/services/decoder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9959      +/-   ##
==========================================
- Coverage   54.53%   54.53%   -0.01%     
==========================================
  Files        1257     1257              
  Lines      156933   156956      +23     
  Branches     3614     3614              
==========================================
+ Hits        85587    85593       +6     
- Misses      71213    71230      +17     
  Partials      133      133              
Flag Coverage Δ
backend 45.15% <100.00%> (-0.01%) ⬇️
harness 72.74% <ø> (ø)
web 54.34% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_experiment.go 56.82% <100.00%> (+0.02%) ⬆️
master/internal/api_runs.go 66.22% <100.00%> (+0.04%) ⬆️
webui/react/src/types.ts 99.70% <100.00%> (+<0.01%) ⬆️
webui/react/src/pages/FlatRuns/columns.ts 18.60% <0.00%> (-0.04%) ⬇️
webui/react/src/services/decoder.ts 21.34% <0.00%> (-0.03%) ⬇️
.../src/pages/TrialDetails/Header/TrialHeaderLeft.tsx 80.39% <41.17%> (-19.61%) ⬇️

... and 5 files with indirect coverage changes

@gt2345 gt2345 requested a review from jgongd September 19, 2024 15:06
Copy link
Contributor

@salonig23 salonig23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some test cases? Also could you check the performance dashboard to make sure that sql script changes do not cause a regression before merging? Everything else looks great!

@gt2345 gt2345 requested a review from jgongd September 24, 2024 14:18
Copy link
Contributor

@jgongd jgongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Nice work!

@gt2345 gt2345 removed the request for review from julian-determined-ai September 24, 2024 21:16
@gt2345
Copy link
Contributor Author

gt2345 commented Sep 24, 2024

Is it possible to add some test cases? Also could you check the performance dashboard to make sure that sql script changes do not cause a regression before merging? Everything else looks great!

@salonig23 Thanks for your feedbacks! As discussed offline, we plan to add test cases to the "write" side of log signal. Also I do see a increase of query time at the perf dashboard, but I doubt that's related to the changes from this PR..

@gt2345 gt2345 requested a review from salonig23 September 24, 2024 22:05
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added few comments, otherwise lgtm

Copy link
Contributor

@salonig23 salonig23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work and thanks for looking into the perf dashboard

@gt2345 gt2345 merged commit 8bc08e5 into main Sep 25, 2024
83 of 95 checks passed
@gt2345 gt2345 deleted the gt/495-log-signal branch September 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants