Fix build on AMD GPUs (related to DeepCompile) #7224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use `torch.utils.cpp_extension.ROCM_HOME`
for ROCm pytorch.
```log
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "DeepSpeed/setup.py", line 195, in <module>
builder.hipify_extension()
File "DeepSpeed/op_builder/builder.py", line 750, in hipify_extension
header_include_dirs=self.include_paths(),
^^^^^^^^^^^^^^^^^^^^
File "DeepSpeed/op_builder/dc.py", line 32, in include_paths
return ['csrc/includes', os.path.join(torch.utils.cpp_extension.CUDA_HOME, "include")]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen posixpath>", line 76, in join
TypeError: expected str, bytes or os.PathLike object, not NoneType
```
Signed-off-by: Hollow Man <[email protected]>
loadams
approved these changes
Apr 17, 2025
tohtana
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use
torch.utils.cpp_extension.ROCM_HOMEfor ROCm pytorch.