Skip to content

Commit af6882a

Browse files
HollowMan6deepcharm
authored andcommitted
Fix build on AMD GPUs (related to DeepCompile) (deepspeedai#7224)
We should use `torch.utils.cpp_extension.ROCM_HOME` for ROCm pytorch. ```log Traceback (most recent call last): File "<string>", line 2, in <module> File "<pip-setuptools-caller>", line 34, in <module> File "DeepSpeed/setup.py", line 195, in <module> builder.hipify_extension() File "DeepSpeed/op_builder/builder.py", line 750, in hipify_extension header_include_dirs=self.include_paths(), ^^^^^^^^^^^^^^^^^^^^ File "DeepSpeed/op_builder/dc.py", line 32, in include_paths return ['csrc/includes', os.path.join(torch.utils.cpp_extension.CUDA_HOME, "include")] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen posixpath>", line 76, in join TypeError: expected str, bytes or os.PathLike object, not NoneType ``` Signed-off-by: Hollow Man <[email protected]> Signed-off-by: Max Kovalenko <[email protected]>
1 parent e03f38b commit af6882a

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

op_builder/dc.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,12 @@ def libraries_args(self):
2929
def include_paths(self):
3030
import os
3131
import torch
32-
return ['csrc/includes', os.path.join(torch.utils.cpp_extension.CUDA_HOME, "include")]
32+
if self.build_for_cpu:
33+
CUDA_INCLUDE = []
34+
elif not self.is_rocm_pytorch():
35+
CUDA_INCLUDE = [os.path.join(torch.utils.cpp_extension.CUDA_HOME, "include")]
36+
else:
37+
CUDA_INCLUDE = [
38+
os.path.join(torch.utils.cpp_extension.ROCM_HOME, "include"),
39+
]
40+
return ['csrc/includes'] + CUDA_INCLUDE

0 commit comments

Comments
 (0)