feat: add response_format param to OllamaChatGenerator
#1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:ollama
type:documentation
Amnah199
commented
Jan 28, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
anakin87
requested changes
Jan 28, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
Amnah199
commented
Jan 29, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
anakin87
reviewed
Jan 29, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
anakin87
approved these changes
Jan 29, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Replacement of PR feat: add
response_formatparam to OllamaChatGenerator #1282Proposed Changes:
Add a new param
response_formatto theOllamaChatGeneratorto support structured outputs.How did you test it?
Updated the tests
Notes for the reviewer
The previous PR got convoluted due to merge conflicts.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.