feat: add response_format param to OllamaChatGenerator
#1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:ollama
type:documentation
|
Hey! |
anakin87
reviewed
Jan 10, 2025
...rations/ollama/src/haystack_integrations/components/generators/ollama/chat/chat_generator.py
Show resolved
Hide resolved
…index (#1277) * fix: Add schema name if dropping index in pgvector store * fix: Remove check for deletion in src * new integration test --------- Co-authored-by: anakin87 <[email protected]>
* progress * Ollama: add support for tools * make generator tests run with llama * PR feedback + simplification
* Add Secret handling in OpenSearchDocumentStore * only serialize auth secrets when values are resolvable * Update integrations/opensearch/src/haystack_integrations/document_stores/opensearch/document_store.py Co-authored-by: tstadel <[email protected]> * Fixes * Revert accidental commit * Special list of Secrets handling only, keep everything else as it was before * Small improvement * More simplifications --------- Co-authored-by: tstadel <[email protected]>
* AmazonBedrockChatGenerator - add tools support * Remove test not needed * Add actual pipeline integration test with tools * Extract instance functions to free standing * No need to test serde on all models * Add serde test * Fix serde test * Lint * Always pack thinking + tool call into single ChatMessage * Revert accidental changes * Method renaming for Python Zen * Add class pydocs * Don't run pipeline in serde test * Update test_serde_in_pipeline test * Lint
* AmazonBedrockGenerator - remove truncation * Update tests * Linting * Remove deprecation test * Update docs config * Update integrations/amazon_bedrock/src/haystack_integrations/components/generators/amazon_bedrock/generator.py Co-authored-by: Stefano Fiorucci <[email protected]> * Lint --------- Co-authored-by: Stefano Fiorucci <[email protected]>
… and Ranker in the type (#1320) * updating amazon-bedrock readme * alphabetical order
Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/fossas/fossa-action/releases) - [Commits](fossas/fossa-action@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: fossas/fossa-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-actions
bot
added
topic:CI
integration:chroma
integration:elasticsearch
integration:opensearch
integration:cohere
integration:google-vertex
integration:qdrant
integration:pinecone
integration:amazon-bedrock
integration:google-ai
integration:llama_cpp
integration:weaviate
integration:astra
integration:pgvector
integration:mongodb-atlas
integration:mistral
integration:optimum
integration:langfuse
integration:azure-ai-search
labels
|
Created a replacement PR #1326 for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add a new param
response_formatto the OllamaChatGenerator to support structured outputs.How did you test it?
Updated the tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.