update: add a new option of absolute volume in /dpgen/dpgen/auto_test/EOS.py #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #741 +/- ##
==========================================
+ Coverage 33.91% 34.84% +0.93%
==========================================
Files 93 93
Lines 16562 16613 +51
==========================================
+ Hits 5617 5789 +172
+ Misses 10945 10824 -121
Continue to review full report at Codecov.
|
AnguseZhang
requested changes
May 30, 2022
AnguseZhang
reviewed
May 30, 2022
AnguseZhang
approved these changes
May 30, 2022
njzjz
requested changes
May 30, 2022
| @@ -24,6 +24,8 @@ def __init__(self, | |||
| self.vol_start = parameter['vol_start'] | |||
| self.vol_end = parameter['vol_end'] | |||
| self.vol_step = parameter['vol_step'] | |||
| parameter['vol_abs'] = parameter.get('vol_abs', False) | |||
There was a problem hiding this comment.
get is applied in other parts of dpgen. To keep consistency, I think it's ok.
There was a problem hiding this comment.
If you mean the other parts in this file, indeed I don't think they are ok. Here set_default is faster and more concise. I can approve this PR though.
njzjz
approved these changes
Jun 12, 2022
ZLI-afk
pushed a commit
to ZLI-afk/dpgen
that referenced
this pull request
Jul 4, 2022
…/EOS.py (deepmodeling#741) * update: add a new option of absolute volume in ./dpgen/auto_test/EOS.py * update: add doc in /dpgen/doc/toymodels/ * update: change the description for eos, change the doc in /dpgen/doc/toymodels/ * update: change the notice of absolute volume from print into dlog.info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: add a new option of absolute volume in /dpgen/dpgen/auto_test/EOS.py