Adapt MemoryOrder definition for C++ 20 #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling the code with C++ 20 the following error message is
produced:
enumerator value for ‘MEMORY_ORDER_RELAXED’ must have integral or unscoped enumeration type
This is because with C++ 20 the type of those values changed to an enum
class. The `static_cast` extracts the numeric values so they can be used
here as before.
|
Thanks for the contributions @SeverinLeonhardt, this one as well as the other two PRs. Unfortunately I've been completely swamped recently (thus the delay in getting back to you) but I'll try to take a look at these PRs next week! |
4 tasks
|
Finally got a chance to take a look at this one @SeverinLeonhardt. That's a nice and elegant way to solve that issue... and degrades nicely for the C++11 case (which is the default). Many thanks for the solid contribution! And again, my apologies for the delay; we're trying to get back on track here. |
absurdfarce
added a commit
that referenced
this pull request
Oct 2, 2023
…e MemoryOrder enum work with C++ 20 but apparently some older gcc instance still want the type_traits include that defines the underlying_type template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the code with C++ 20 the following error message is produced:
This is because with C++ 20 the type of those values changed to an enum class. The
static_castextracts the numeric values so they can be used here as before.