Skip to content

cassandra-cpp-driver: add version 2.16.2, support conan v2 #14509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 19, 2023
Merged

cassandra-cpp-driver: add version 2.16.2, support conan v2 #14509

merged 9 commits into from
Aug 19, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 1, 2022

Specify library name and version: cassandra-cpp-driver/*

@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 1, 2022
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Jan 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 16, 2023
@stale stale bot removed the stale label Feb 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Mar 19, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Apr 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 25, 2023
@ericLemanissier ericLemanissier mentioned this pull request May 13, 2023
Closed
@stale stale bot removed the stale label May 22, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 31f0373
cassandra-cpp-driver/2.16.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcassandra.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcassandra.2.16.2.dylib, libcassandra.2.dylib, libcassandra.dylib
cassandra-cpp-driver/2.15.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcassandra.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcassandra.2.15.3.dylib, libcassandra.2.dylib, libcassandra.dylib

@prince-chrismc prince-chrismc mentioned this pull request Jun 26, 2023
Merged
@toge toge closed this Jul 9, 2023
@toge toge reopened this Jul 9, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Jul 11, 2023
View reviewed changes
recipes/cassandra-cpp-driver/all/conandata.yml Outdated
Comment on lines 29 to 30
- patch_file: "patches/2.15.3/fix-atomic.patch"
patch_description: "add static_cast for atomic enum"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- patch_file: "patches/2.15.3/fix-atomic.patch"
patch_description: "add static_cast for atomic enum"
- patch_file: "patches/2.15.3/fix-atomic.patch"
patch_description: "Adapt MemoryOrder definition for C++ 20"
patch_source: "https://github.com/datastax/cpp-driver/pull/533"

Could you please use datastax/cpp-driver#533 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks your advise!
I will update this recipe.

recipes/cassandra-cpp-driver/all/conanfile.py Outdated

if self.options.use_atomic == "boost":
self.requires("boost/1.79.0")
self.requires("boost/1.81.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("boost/1.81.0")
self.requires("boost/1.82.0")

Is it possible to use Boost 1.82.0, or is there a conflict?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason.
I update it.

recipes/cassandra-cpp-driver/all/patches/2.15.3/remove-attribute-for-msvc.patch

template <bool> struct SparsehashCompileAssert { };
+#if defined(_MSC_VER)
+#define SPARSEHASH_COMPILE_ASSERT(expr, msg) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find an issue related to this, so I need to ask: What's the error when this patch is not applied?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries
Without this patch, following message is occured.

.conan2\p\b\cassa8ae3c63d48e8d\b\src\src\third_party\sparsehash\src\sparsehash/internal/hashtable-common.h(166,3): error C2065: 'unused': 定義されていない識別子です。

Sorry for Japanese error message.
It means "'unused' is an undefined identifier".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit a8fc6b2
cassandra-cpp-driver/2.16.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcassandra.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcassandra.2.16.2.dylib, libcassandra.2.dylib, libcassandra.dylib
cassandra-cpp-driver/2.15.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcassandra.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libcassandra.2.15.3.dylib, libcassandra.2.dylib, libcassandra.dylib

@stale
Copy link

stale bot commented Aug 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2023
@stale stale bot removed the stale label Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries
Copy link
Member

We are checking this OpenSSL error, don't worry.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (ea0030ca52ec5bf06fa665b2bc85a32d9136735b):

  • cassandra-cpp-driver/2.16.2:
    All packages built successfully! (All logs)

  • cassandra-cpp-driver/2.15.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (ea0030ca52ec5bf06fa665b2bc85a32d9136735b):

  • cassandra-cpp-driver/2.15.3:
    All packages built successfully! (All logs)

  • cassandra-cpp-driver/2.16.2:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit c23c100 into conan-io:master Aug 19, 2023
ericLemanissier pushed a commit to ericLemanissier/cocorepo that referenced this pull request Sep 15, 2023
@toge @uilianries @ericLemanissier
(conan-io#14509) cassandra-cpp-driver: add version 2.16.2, support co…
cd288b7 
…nan v2

* cassandra-cpp-driver: add version 2.16.2, support conan v2

* fix library name, specify C++11

* add transitive_headers=True

* update dependencies

* fix compilation error on msvc

* update dependencies, improve patch file

* enable C++11, include type_traits

---------

Co-authored-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @uilianries @SSE4