Skip to content

[Internal] Bump Go SDK to latest release + Generate TF Structs #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Apr 14, 2025

Changes

Bump Go SDK to latest release + Generate TF Structs

Tests

CI Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db requested review from a team as code owners April 14, 2025 15:20
@tanmay-db tanmay-db requested review from hectorcast-db and removed request for a team April 14, 2025 15:20
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 15:20 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 15:21 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 15:21 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 15:22 — with GitHub Actions Inactive
@tanmay-db tanmay-db marked this pull request as draft April 14, 2025 15:24
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 16:04 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 14, 2025 16:04 — with GitHub Actions Inactive
@tanmay-db tanmay-db marked this pull request as ready for review April 14, 2025 16:05
@tanmay-db tanmay-db changed the title [Internal] Bump Go SDK to latest release [Internal] Bump Go SDK to latest release + Generate TF Structs Apr 14, 2025
@tanmay-db tanmay-db requested review from rauchy, mgyucht and alexott April 14, 2025 16:06
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 15, 2025 09:52 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 15, 2025 09:52 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 15, 2025 09:52 — with GitHub Actions Inactive
@tanmay-db tanmay-db requested a review from rauchy April 15, 2025 09:53
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 15, 2025 09:53 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4645
  • Commit SHA: e325bf153b46987e03f8eaea14b0bba8c2c65b3f

Checks will be approved automatically on success.

@tanmay-db tanmay-db added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit be82cb1 Apr 15, 2025
12 checks passed
@tanmay-db tanmay-db deleted the go-sdk-bump-14april branch April 15, 2025 14:17
deco-sdk-tagging bot added a commit that referenced this pull request Apr 15, 2025
## Release v1.73.0

### New Features and Improvements

 * Add a new settings resource `databricks_disable_legacy_dbfs_setting` ([#4605](#4605))
 * Support for `lifetime` attribute in `databricks_service_principal_secret` resource ([#4633](#4633)).
 * Mark `databricks_sql_dashaboard` as deprecated ([#4641](#4641))

### Bug Fixes

 * Increase the default HTTP timeout to 65 seconds.

### Documentation

 * Document `user_api_scopes` in `databricks_app` resource and data sources ([#4614](#4614))
 * Document new fields in `databricks_model_serving` resource ([#4615](#4615))

### Exporter

 * Add export of `databricks_mws_network_connectivity_config` and `databricks_mws_ncc_private_endpoint_rule` ([#4613](#4613))

### Internal Changes

* Refactor `databricks_mws_workspaces` resource and datasource, as well as `databricks_mws_ncc_binding`, to use the Go SDK ([#4633](#4633)).
* Add `TestMwsAccGcpWorkspaces` and `TestMwsAccGcpByovpcWorkspaces` to flaky test ([#4624](#4624)).
* Bump Go SDK to latest release ([#4645](#4645))
attrs["workspace_status"] = attrs["workspace_status"].SetComputed()
attrs["workspace_status"] = attrs["workspace_status"].SetOptional()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanmay-db I think that it's wrong.

attrs["vpc_status"] = attrs["vpc_status"].SetComputed()
attrs["vpc_status"] = attrs["vpc_status"].SetOptional()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanmay-db I think that it's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants