Skip to content

[Internal] Add TestMwsAccGcpWorkspaces to flaky test #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Apr 8, 2025

Changes

GCP workspace creation has been unstable due to stale resource cleanups such as policy limit, VPC limits, firewall limits etc.. We are marking them as flaky to have a stable infrastructure.

Tests

N/A

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@tanmay-db tanmay-db requested review from a team as code owners April 8, 2025 14:05
@tanmay-db tanmay-db requested review from renaudhartert-db and removed request for a team April 8, 2025 14:05
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:05 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:05 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:06 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:07 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:15 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 8, 2025 14:15 — with GitHub Actions Inactive
Copy link

github-actions bot commented Apr 8, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4624
  • Commit SHA: 46ae5cff2c6e115c427145bd6ab6f828a09443ee

Checks will be approved automatically on success.

@tanmay-db tanmay-db requested review from mgyucht and removed request for a team and renaudhartert-db April 8, 2025 14:15
@alexott alexott enabled auto-merge April 8, 2025 14:28
@alexott alexott added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit d6752e1 Apr 8, 2025
13 checks passed
@alexott alexott deleted the fix-tests-1 branch April 8, 2025 15:25
deco-sdk-tagging bot added a commit that referenced this pull request Apr 10, 2025
## Release v1.73.0

### New Features and Improvements

 * Add a new settings resource `databricks_disable_legacy_dbfs_setting` ([#4605](#4605))

### Bug Fixes

 * Increase the default HTTP timeout to 65 seconds.

### Documentation

 * Document `user_api_scopes` in `databricks_app` resource and data sources ([#4614](#4614))
 * Document new fields in `databricks_model_serving` resource ([#4615](#4615))

### Exporter

 * Add export of `databricks_mws_network_connectivity_config` and `databricks_mws_ncc_private_endpoint_rule` ([#4613](#4613))

### Internal Changes

* Add `TestMwsAccGcpWorkspaces` and `TestMwsAccGcpByovpcWorkspaces` to flaky test ([#4624](#4624)).
deco-sdk-tagging bot added a commit that referenced this pull request Apr 15, 2025
## Release v1.73.0

### New Features and Improvements

 * Add a new settings resource `databricks_disable_legacy_dbfs_setting` ([#4605](#4605))
 * Support for `lifetime` attribute in `databricks_service_principal_secret` resource ([#4633](#4633)).
 * Mark `databricks_sql_dashaboard` as deprecated ([#4641](#4641))

### Bug Fixes

 * Increase the default HTTP timeout to 65 seconds.

### Documentation

 * Document `user_api_scopes` in `databricks_app` resource and data sources ([#4614](#4614))
 * Document new fields in `databricks_model_serving` resource ([#4615](#4615))

### Exporter

 * Add export of `databricks_mws_network_connectivity_config` and `databricks_mws_ncc_private_endpoint_rule` ([#4613](#4613))

### Internal Changes

* Refactor `databricks_mws_workspaces` resource and datasource, as well as `databricks_mws_ncc_binding`, to use the Go SDK ([#4633](#4633)).
* Add `TestMwsAccGcpWorkspaces` and `TestMwsAccGcpByovpcWorkspaces` to flaky test ([#4624](#4624)).
* Bump Go SDK to latest release ([#4645](#4645))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants