Skip to content

[Doc] Remove mention that databricks_credential is storage-only on GCP #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[Doc] Remove mention that databricks_credential is storage-only on GCP #4460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b586b24
[Doc] Remove mention that `databricks_credential` is storage-only on GCP
alexott Feb 3, 2025
a628456
add changelog entry
alexott Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### Documentation

* Fix attribute name in `databricks_instance_profile` examples ([#4426](https://github.com/databricks/terraform-provider-databricks/pull/4426)).
* Remove mention that databricks_credential is storage-only on GCP ([#4460](https://github.com/databricks/terraform-provider-databricks/pull/4460)).

### Exporter

Expand Down
6 changes: 3 additions & 3 deletions docs/resources/credential.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ resource "databricks_grants" "external_creds" {
}
```

For GCP (only applicable when purpose is `STORAGE`)
For GCP

```hcl
resource "databricks_credential" "external_gcp_sa" {
name = "gcp_sa_credential"
databricks_gcp_service_account {}
purpose = "STORAGE"
purpose = "SERVICE"
comment = "GCP SA credential managed by TF"
}

Expand Down Expand Up @@ -106,7 +106,7 @@ The following arguments are required:
- `application_id` - The application ID of the application registration within the referenced AAD tenant
- `client_secret` - The client secret generated for the above app ID in AAD. **This field is redacted on output**

`databricks_gcp_service_account` optional configuration block for creating a Databricks-managed GCP Service Account. Only applicable when purpose is `STORAGE`:
`databricks_gcp_service_account` optional configuration block for creating a Databricks-managed GCP Service Account:

- `email` (output only) - The email of the GCP service account created, to be granted access to relevant buckets.

Expand Down
5 changes: 2 additions & 3 deletions internal/acceptance/credential_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ func awsCredentialWithComment(comment string) string {
}

func gcpCredentialWithComment(comment string) string {
// TODO: update purpose to SERVICE when it's released
return fmt.Sprintf(`
resource "databricks_credential" "external" {
name = "storage-cred-{var.STICKY_RANDOM}"
name = "service-cred-{var.STICKY_RANDOM}"
databricks_gcp_service_account {}
purpose = "STORAGE"
purpose = "SERVICE"
skip_validation = true
comment = "%s"
}`, comment)
Expand Down
Loading