Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Remove mention that databricks_credential is storage-only on GCP #4460

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 3, 2025

Changes

As we started supporting service credentials on GCP, documentation should be updated to remove that databricks_credential could be used only with purpose = "STORAGE".

Also, updated integration test to use purpose = "SERVICE".

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

As we started supporting service credentials on GCP, documentation should be updated to
remove that `databricks_credential` could be used only with `purpose = "STORAGE"`.

Also, updated integration test to use `purpose = "SERVICE"`.
@alexott alexott requested review from a team as code owners February 3, 2025 09:17
@alexott alexott requested review from mgyucht and removed request for a team February 3, 2025 09:17
@alexott alexott temporarily deployed to test-trigger-is February 3, 2025 09:17 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is February 3, 2025 09:17 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is February 3, 2025 09:18 — with GitHub Actions Inactive
Copy link

github-actions bot commented Feb 3, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4460
  • Commit SHA: a628456b4491e9066a19f91328abeb3274e717cd

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is February 3, 2025 09:18 — with GitHub Actions Inactive
@mgyucht mgyucht added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit bcc5c11 Feb 3, 2025
13 checks passed
@mgyucht mgyucht deleted the doc/gcp-service-credentials branch February 3, 2025 10:34
deco-sdk-tagging bot pushed a commit that referenced this pull request Feb 4, 2025
## Release v1.65.0

### New Features and Improvements

 * Add resources for AI/BI Dashboards embedding settings: `databricks_aibi_dashboard_embedding_access_policy_setting` and `databricks_aibi_dashboard_embedding_approved_domains_setting` ([#4213](#4213)).
 * Update Databricks Go SDK to v0.57.0.

### Bug Fixes

 * Make removing the `config` attribute of `databricks_model_serving` a no-op ([#4446](#4446)).

   This change allows integrations, such as DABs, to manage & update the configuration of a model serving endpoint independently of the lifecycle of the endpoint itself.
 * Correctly handle PAT and OBO tokens without expiration ([#4444](#4444)).
 * Mark `task.spark_jar_task.run_as_repl` as `computed` to fix configuration drift ([#4452](#4452)).
 * Recreate `databricks_external_location` when its name changes ([#4467](#4467)).

### Documentation

 * Fix attribute name in `databricks_instance_profile` examples ([#4426](#4426)).
 * Remove mention that databricks_credential is storage-only on GCP ([#4460](#4460)).
 * Officially document `databricks_table` as deprecated. Users of this resource should migrate to `databricks_sql_table`. See https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_table for more information.
 * Improve examples and fix headers layout for `databricks_job` ([#4455](#4455)).

### Internal Changes

 * Refactored existing integration tests from the `internal/acceptance` package to the package corresponding to the resource under test. See `CONTRIBUTING.md` for more information on how to run the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants