Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Remove default onData for transformByHandlers #187

Merged
merged 1 commit into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/src/from_handlers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ extension TransformByHandlers<S> on Stream<S> {
/// that the handlers are called once per event rather than called for the
/// same event for each listener on a broadcast stream.
Stream<T> transformByHandlers<T>(
{void Function(S, EventSink<T>)? onData,
{required void Function(S, EventSink<T>) onData,
void Function(Object, StackTrace, EventSink<T>)? onError,
void Function(EventSink<T>)? onDone}) {
final handleData = onData ?? _defaultHandleData;
final handleError = onError ?? _defaultHandleError;
final handleDone = onDone ?? _defaultHandleDone;

Expand All @@ -26,7 +25,7 @@ extension TransformByHandlers<S> on Stream<S> {
controller.onListen = () {
assert(subscription == null);
var valuesDone = false;
subscription = listen((value) => handleData(value, controller),
subscription = listen((value) => onData(value, controller),
onError: (Object error, StackTrace stackTrace) {
handleError(error, stackTrace, controller);
}, onDone: () {
Expand All @@ -48,10 +47,6 @@ extension TransformByHandlers<S> on Stream<S> {
return controller.stream;
}

static void _defaultHandleData<S, T>(S value, EventSink<T> sink) {
sink.add(value as T);
}

static void _defaultHandleError<T>(
Object error, StackTrace stackTrace, EventSink<T> sink) {
sink.addError(error, stackTrace);
Expand Down
7 changes: 4 additions & 3 deletions test/from_handlers_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ void main() {
group('default from_handlers', () {
group('Single subscription stream', () {
setUp(() {
setUpForController(StreamController(), (s) => s.transformByHandlers());
setUpForController(StreamController(),
(s) => s.transformByHandlers(onData: (e, sink) => sink.add(e)));
});

test('has correct stream type', () {
Expand Down Expand Up @@ -75,8 +76,8 @@ void main() {
late StreamSubscription<int> subscription2;

setUp(() {
setUpForController(
StreamController.broadcast(), (s) => s.transformByHandlers());
setUpForController(StreamController.broadcast(),
(s) => s.transformByHandlers(onData: (e, sink) => sink.add(e)));
emittedValues2 = [];
errors2 = [];
isDone2 = false;
Expand Down