This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Remove default onData for transformByHandlers #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards #111 The default callback is not used in practice outside of tests, but it included a cast to satisfy the type signature which looks worrying for this type of library. Make the callback required and add explicit callbacks (without a cast since the types are consistent) in the tests which used it.
lrhn
approved these changes
Jun 13, 2024
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…ansform#187) Towards dart-lang/stream_transform#111 The default callback is not used in practice outside of tests, but it included a cast to satisfy the type signature which looks worrying for this type of library. Make the callback required and add explicit callbacks (without a cast since the types are consistent) in the tests which used it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards dart-lang/tools#1771
The default callback is not used in practice outside of tests, but it
included a cast to satisfy the type signature which looks worrying for
this type of library.
Make the callback required and add explicit callbacks (without a cast
since the types are consistent) in the tests which used it.