Skip to content

chore: add minimal built-ins back in to @cypress/webpack-batteries-included-preprocessor #31815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/15.0.0
Choose a base branch
from

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jun 2, 2025

  • Closes N/A

Additional details

After removing all the webpack 4 built-ins from Cypress 15, We realized that some built-ins should likely be shipped with @cypress/webpack-batteries-included-preprocessor in order to not make the change as disruptive. These built-ins are the commonly used node built-ins from observation and happen to be buffer, path, process, os, and stream

Steps to test

Should now work where process and buffer are used.

How has the user experience changed?

Should make the change less disruptive if using any of the above built ins. Otherwise, no change is realized to the end user

PR Tasks

Copy link

cypress bot commented Jun 2, 2025

cypress    Run #62857

Run Properties:  status check passed Passed #62857  •  git commit 32e1c9d4a4: chore: re-add the buffer, path, process, os, and stream built-ins to wbip
Project cypress
Branch Review feat/add_built_ins_minimal
Run status status check passed Passed #62857
Run duration 08m 43s
Commit git commit 32e1c9d4a4: chore: re-add the buffer, path, process, os, and stream built-ins to wbip
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 67
View all changes introduced in this branch ↗︎
UI Coverage  42.62%
  Untested elements 32  
  Tested elements 26  
Accessibility  92.49%
  Failed rules  0 critical   4 serious   0 moderate   0 minor
  Failed elements 83  

@AtofStryker AtofStryker self-assigned this Jun 4, 2025
@AtofStryker
Copy link
Contributor Author

The test-binary-against-recipes is going to fail because @cypress/webpack-batteries-included-preprocessor is lacking the crypto built-in, which we intentionally removed due to a security vulnerability with elliptic( see #31039 and PR #31738). If we install the current @cypress/webpack-batteries-included-preprocessor on npm inside example recipes, the built-in is provided and we don't need to configure it, which we don't want long term. I'd prefer we fix the test when @cypress/webpack-batteries-included-preprocessor releases the breaking change version. I added this step to the Cypress 15 release steps.

@AtofStryker AtofStryker mentioned this pull request Jun 5, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant