Skip to content

Regression test for ground-truth jobs from video #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 28, 2025

Conversation

archibald1418
Copy link
Contributor

@archibald1418 archibald1418 commented Feb 26, 2025

This provides coverage for fix #9095

Motivation and context

How has this been tested?

  • Generate new task from existing videofile with 3 frames
  • Create new ground truth job, picking 1 frame (the bug manifests when frame index is greater than frameCount)
  • Go to job, play the frames. No crashes should happen

feature test ground_truth_jobs.js already contains regression tests, so this test updates that. A separate describe block is added with separate hooks to generate a gt-task from video

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@archibald1418 archibald1418 requested review from klakhov and removed request for bsekachev February 26, 2025 10:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (e4b2e34) to head (9f24da3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9150   +/-   ##
========================================
  Coverage    73.32%   73.32%           
========================================
  Files          448      448           
  Lines        45862    45862           
  Branches      3914     3914           
========================================
+ Hits         33627    33628    +1     
+ Misses       12235    12234    -1     
Components Coverage Δ
cvat-ui 77.08% <ø> (+<0.01%) ⬆️
cvat-server 70.31% <ø> (ø)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archibald1418 archibald1418 merged commit 8c34848 into develop Feb 28, 2025
33 of 34 checks passed
@archibald1418 archibald1418 deleted the ov/test-gt-video-frame-navigation-bug branch February 28, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants