Fix: Cannot read properties of undefined (reading 'width') in Video GT job #9095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
reviewed
Feb 12, 2025
klakhov
force-pushed
the
kl/frame-regression
branch
from
5b555c4 to
d5be48e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9095 +/- ##
===========================================
+ Coverage 73.91% 73.94% +0.02%
===========================================
Files 428 428
Lines 44530 44532 +2
Branches 3881 3881
===========================================
+ Hits 32916 32930 +14
+ Misses 11614 11602 -12
|
bsekachev
approved these changes
Feb 12, 2025
|
Merged
archibald1418
pushed a commit
that referenced
this pull request
Feb 26, 2025
6 tasks
archibald1418
added a commit
that referenced
this pull request
Feb 28, 2025
This provides coverage for fix #9095 ### Motivation and context ### How has this been tested? - Generate new task from existing videofile with 3 frames - Create new ground truth job, picking 1 frame (the bug manifests when frame index is greater than `frameCount`) - Go to job. The job should open correctly (canvas exists and visible). No crashes should happen. No error notifications should appear. feature test `ground_truth_jobs.js` already contains regression tests, so this test updates that. A separate `describe` block is added with separate hooks to generate a gt-task from video ### Checklist - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. --------- Co-authored-by: Oleg Valiulin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
It seems that a regression was introduced during recent refactoring related to frame metadata. In a GT job created from a video, navigating through frames results in an error: *Cannot read properties of undefined (reading 'width').
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.