Skip to content

Undefined SerializationTypeMismatch error #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Undefined SerializationTypeMismatch error #5

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c586c79
Define currently undefined GigoCoder::SerializationTypeMismatch error
mnishiguchi Feb 2, 2022
f3738ab
Fix SerializationTypeMismatch error message
mnishiguchi Feb 2, 2022
991a5c7
Include a value in the error message for debuging ease
mnishiguchi Feb 2, 2022
5aab2ec
Use ActiveRecord::SerializationTypeMismatch instead of custom GigoCod…
mnishiguchi Feb 2, 2022
6f0996c
Bump version to 2.0.2
mnishiguchi Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/gigo/active_record/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def load(yaml)
Encoding.default_internal = GIGO.encoding
value = YAML.load(GIGO.load(yaml))
unless value.is_a?(klass)
raise SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{hash.class}."
raise ::ActiveRecord::SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{value.class}: #{value.inspect}"
end
value
ensure
Expand All @@ -64,7 +64,7 @@ def load(yaml)
def dump(value)
return klass.new.to_yaml if value.nil?
unless value.is_a?(klass)
raise SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{value.class}."
raise ::ActiveRecord::SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{value.class}: #{value.inspect}"
end
value.to_yaml
end
Expand All @@ -74,4 +74,3 @@ def dump(value)
end

ActiveRecord::Base.extend GIGO::ActiveRecord::Base