Undefined SerializationTypeMismatch error

[mnishiguchi]

Description

Currently GigoCoder::SerializationTypeMismatch is not defined, which causes the following error in the gem user app:

NameError: uninitialized constant GIGO::ActiveRecord::Base::GigoCoder::SerializationTypeMismatch

The error message is right. We need to define our custom error before using it.

gigo-activerecord/lib/gigo/active_record/base.rb

Lines 52 to 70 in 87c03b4

	def load(yaml)
	return klass.new if yaml.nil?
	Encoding.default_internal = GIGO.encoding
	value = YAML.load(GIGO.load(yaml))
	unless value.is_a?(klass)
	raise SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{hash.class}."
	end
	value
	ensure
	Encoding.default_internal = @default_internal
	end
	def dump(value)
	return klass.new.to_yaml if value.nil?
	unless value.is_a?(klass)
	raise SerializationTypeMismatch, "Attribute was supposed to be a #{klass.to_s}, but was a #{value.class}."
	end
	value.to_yaml
	end

Related PR: #3

Changes

• Define GigoCoder::SerializationTypeMismatch Use fully-qualified error name ::ActiveRecord::SerializationTypeMismatch
• Correct the error message: hash is probably a typo, meant to be value
• Show the value in the error message

Notes

• Alternatively we could make the error be a generic RuntimeError
• This bug was discovered in our Rails Backend Rails 5.0 QA.
• It would be nice to be able to see actual value in the error message for debuggability

[metaskills]

I think the intent here was that we had implicit access to the ActiveRecord::SerializationTypeMismatch because this is an ActiveRecord gem. So if we are not getting into that scope correctly because of the way we have authored the gem or using it in a certain way, perhaps we should change the rails to ::ActiveRecord::SerializationTypeMismatch instead?

[metaskills]

This is the error we were trying to raise. https://api.rubyonrails.org/classes/ActiveRecord/SerializationTypeMismatch.html It is old as dirt and consistent between Rails versions and meant to be the one to communicate a serialization error.