Skip to content

Fix issue with hook steps not being rendered #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 19, 2025
Merged

Fix issue with hook steps not being rendered #379

merged 5 commits into from
Apr 19, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 17, 2025

🤔 What's changed?

  • <HookStep/> now only attempts to render a step if attachments has a truthy length.
  • <HookSteps/> no longer incorrectly filters out steps that should be rendered.
  • <StepsList/> now has better targeted CSS so that empty list items don't cause a spacing issue

⚡️ What's your motivation?

Fixes #378.

Reverts the change that introduced this bug and solves the original problem in a better way.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 5649f1a
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/680143ef70e12900098c4e50
😎 Deploy Preview https://deploy-preview-379--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss marked this pull request as ready for review April 19, 2025 09:57
@davidjgoss davidjgoss merged commit 01f53ca into main Apr 19, 2025
6 checks passed
@davidjgoss davidjgoss deleted the 378 branch April 19, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachments from before&after hooks are no longer shown
1 participant