Skip to content

Attachments from before&after hooks are no longer shown #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kouzukii opened this issue Apr 16, 2025 · 4 comments · Fixed by #379
Closed

Attachments from before&after hooks are no longer shown #378

Kouzukii opened this issue Apr 16, 2025 · 4 comments · Fixed by #379
Assignees

Comments

@Kouzukii
Copy link

👓 What did you see?

We use attachments to add video and trace information in an after() hook.
I have verified that the window.CUCUMBER_MESSAGES block is the same between cucumber-jvm 7.21.1 and 7.22.0
My only explanation is that the latest react-components have tied attachments to testStepId which don't resolve for before() and after() hooks

Image

✅ What did you expect to see?

The same test run with cucumber-jvm 7.21.1

Image

📦 Which tool/library version are you using?

java 21
cucumber-jvm 7.22.0

🔬 How could we reproduce it?

class Setup {
  @Before
  fun before(scenario: Scenario) {
    scenario.log("TEST!")
  }
}

📚 Any additional context?

No response

@Kouzukii Kouzukii changed the title Attachments from before&after Hooks are no longer shown Attachments from before&after hooks are no longer shown Apr 16, 2025
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Apr 16, 2025

As a workaround you can downgrade the io.cucumber:html-formatter to 21.9.0.

@mpkorstanje
Copy link
Contributor

Looking at the changelog #361 is suspect.

@mpkorstanje
Copy link
Contributor

And this issue sounds similar to cucumber/html-formatter#363.

@davidjgoss
Copy link
Contributor

This was fixed in the formatter package as of https://github.com/cucumber/html-formatter/releases/tag/v21.10.1 - sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants