Feat/monthly reports #508
Merged
Feat/monthly reports #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonshumway-ia
force-pushed
the
feat/monthly-reports
branch
from
b228930 to
f813251
Compare
While running this lambda in our test env, we encountered quantity data returned from the authorize.net account in the format '1.0' we never expect to have partial quantities of items, so we need to cast these to floats before casting them to integers.
This was accidentally dropped during a rebase
For some reason, week_day 5 is showing up as Thursday on the event bridge schedule, but we want this to run on Friday. This uses the day abbreviation to explicitly set the schedule to Friday.
landonshumway-ia
force-pushed
the
feat/monthly-reports
branch
from
957afa9 to
cb1a03c
Compare
jusdino
suggested changes
Feb 3, 2025
backend/compact-connect/lambdas/nodejs/tests/email-notification-service-lambda.test.ts
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/stacks/persistent_stack/transaction_reports_bucket.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
- comments describing purpose of .gz files - remove unneeded cors policies from transaction report bucket
jusdino
suggested changes
Feb 5, 2025
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
...-connect/lambdas/python/purchases/tests/function/test_handlers/test_transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
jusdino
approved these changes
Feb 5, 2025
jlkravitz
reviewed
Feb 5, 2025
backend/compact-connect/lambdas/nodejs/tests/email-notification-service-lambda.test.ts
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_history.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/purchases/handlers/transaction_reporting.py
Show resolved
Hide resolved
Given that we don't have hard requirements for how admins will access these reports outside of email messages, this removes the unnecessary complexity of storing .gz files.
jlkravitz
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Looks great! Thanks for clarifying the tests. @isabeleliassen Good to merge.
|
@jlkravitz still some unresolved conversations I think! |
|
@isabeleliassen those have now been resolved. This should be ready to go. Thanks. |
isabeleliassen
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSG has requested that we implement automated monthly transaction reporting. This required several updates to increase the number of transactions that could be handled within a single report. Previously we were passing in the full csv report string to the email-service lambda payload, which was prone to a 6MB file size limit, now we are storing these reports in a compressed zip format in S3, and passing in the S3 key to the email service so it can pull down the file and attach the zip file to the email directly. This adds the needed infrastructure to support monthly reporting in a scaleable manner.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #493