Add time window edge case testing

Author: jusdino

backend/compact-connect/lambdas/python/common/tests/function/__init__.py

@@ -37,12 +37,14 @@ def build_resources(self):
         self.create_compact_configuration_table()
         self.create_provider_table()
         self.create_users_table()
+        self.create_transaction_history_table()
 
         # Adding a waiter allows for testing against an actual AWS account, if needed
         waiter = self._compact_configuration_table.meta.client.get_waiter('table_exists')
         waiter.wait(TableName=self._compact_configuration_table.name)
         waiter.wait(TableName=self._provider_table.name)
         waiter.wait(TableName=self._users_table.name)
+        waiter.wait(TableName=self._transaction_history_table.name)
 
         # Create a new Cognito user pool
         cognito_client = boto3.client('cognito-idp')
@@ -122,15 +124,29 @@ def create_provider_table(self):
             ],
         )
 
+    def create_transaction_history_table(self):
+        self._transaction_history_table = boto3.resource('dynamodb').create_table(
+            KeySchema=[{'AttributeName': 'pk', 'KeyType': 'HASH'}, {'AttributeName': 'sk', 'KeyType': 'RANGE'}],
+            AttributeDefinitions=[
+                {'AttributeName': 'pk', 'AttributeType': 'S'},
+                {'AttributeName': 'sk', 'AttributeType': 'S'},
+            ],
+            TableName=os.environ['TRANSACTION_HISTORY_TABLE_NAME'],
+            BillingMode='PAY_PER_REQUEST',
+        )
+
     def delete_resources(self):
         self._compact_configuration_table.delete()
         self._provider_table.delete()
         self._users_table.delete()
+        self._transaction_history_table.delete()
 
         waiter = self._users_table.meta.client.get_waiter('table_not_exists')
         waiter.wait(TableName=self._compact_configuration_table.name)
         waiter.wait(TableName=self._provider_table.name)
         waiter.wait(TableName=self._users_table.name)
+        waiter = self._transaction_history_table.meta.client.get_waiter('table_not_exists')
+        waiter.wait(TableName=self._transaction_history_table.name)
 
         # Delete the Cognito user pool
         cognito_client = boto3.client('cognito-idp')

backend/compact-connect/lambdas/python/common/tests/function/test_data_model/test_transaction_client.py

@@ -0,0 +1,61 @@
+from datetime import datetime
+
+from moto import mock_aws
+
+from .. import TstFunction
+
+
+@mock_aws
+class TestClient(TstFunction):
+    def test_transaction_history_edge_times(self):
+        """
+        Test for internal consistency in how transactions are stored and reported, when times land
+        right on the edge of the reporting window.
+        """
+        from cc_common.data_model.transaction_client import TransactionClient
+
+        client = TransactionClient(self.config)
+
+        # Create some records on the edge of the window we want to query
+        start_time_string = '2024-01-01T00:00:00Z'
+        end_time_string = '2024-01-08T00:00:00Z'
+        start_time = datetime.fromisoformat(start_time_string)
+        end_time = datetime.fromisoformat(end_time_string)
+
+        client.store_transactions(
+            compact='aslp',
+            transactions=[
+                # One at the beginning of the window
+                {
+                    'transactionId': '123',
+                    'transactionProcessor': 'authorize.net',
+                    'batch': {'batchId': 'abc', 'settlementTimeUTC': start_time_string},
+                },
+                # One at the end of the window
+                {
+                    'transactionId': '456',
+                    'transactionProcessor': 'authorize.net',
+                    'batch': {'batchId': 'def', 'settlementTimeUTC': end_time_string},
+                },
+            ],
+        )
+
+        # Query the transactions in the window
+        transactions = client.get_transactions_in_range(
+            compact='aslp',
+            start_epoch=int(start_time.timestamp()),
+            end_epoch=int(end_time.timestamp()),
+        )
+
+        # We expect to get the first back but not the second. Any more or less will result in
+        # under or over reporting of transactions across reports.
+        self.assertEqual(
+            {
+                'pk': 'COMPACT#aslp#TRANSACTIONS#MONTH#2024-01',
+                'sk': 'COMPACT#aslp#TIME#1704067200#BATCH#abc#TX#123',
+                'transactionId': '123',
+                'transactionProcessor': 'authorize.net',
+                'batch': {'batchId': 'abc', 'settlementTimeUTC': start_time_string},
+            },
+            transactions[0],
+        )