Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/military affiliation #426

Merged

Conversation

ChiefStief
Copy link
Collaborator

@ChiefStief ChiefStief commented Jan 7, 2025

Requirements List

  • A working LicenseeUser account

Description List

  • Added in Military Status page
  • Added in Update Military Status page
  • Added in store + network modules needed to facilitate pages' functionality
  • Updated Licensee model and serializer to capture military affiliations api implementation
  • Added military affiliations model and serializer
  • Edited FinalizePrivilegePurchase page and SelectedStatePurchaseInformation component to refer to both the state and user's military status to make a military discount determination
  • Fixed bug in InputRadioGroup component causing multi-line labels to break layout
  • Added / updated tests as needed

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • On both mock and real api and in all screen sizes:
  1. click on the view military status button to view your status page
  2. Click edit info to go the doc upload page
  3. Fill out the form, confirm it does not allow submission with no select choice and no / invalid document selection
  4. Submit
  5. View your updated military status (real api only)
  6. Go through the privilege purchase flow and notice military affiliation discount is being applied
  7. Return to the military status screen; try ending your military status
  8. Status should now be inactive
  9. Go back through privilege purchase flow, confirm military affiliation is no longer being applied

Closes #281

Notes:

  • The real API system only saves one document upload submission per day. It will replace a prior submission in the day with your most recent one
  • The document upload is eventually consistent so your status may not immediately update. I've found it to take ~1 second but theoretically it could be longer.

@ChiefStief ChiefStief marked this pull request as ready for review January 9, 2025 00:50
@ChiefStief ChiefStief requested a review from jsandoval81 January 9, 2025 00:50
Copy link
Collaborator

@jsandoval81 jsandoval81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid 👍

This was a mostly code review. I'll take a deeper dive in the UI on the next pass.

@ChiefStief ChiefStief changed the title Feat/militar affiliation Feat/military affiliation Jan 9, 2025
@ChiefStief ChiefStief requested a review from jsandoval81 January 9, 2025 23:57
Copy link
Collaborator

@jsandoval81 jsandoval81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks solid. Just a few trailing items that are pretty minor.

@jsandoval81
Copy link
Collaborator

@jlkravitz This is ready for your review.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! a few small nits.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge.

@isabeleliassen isabeleliassen merged commit 32788ec into csg-org:development Jan 13, 2025
1 check passed
@jlkravitz jlkravitz mentioned this pull request Jan 21, 2025
15 tasks
@jsandoval81 jsandoval81 deleted the feat/militar-affiliation branch January 29, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

military affiliation confirmation frontend
4 participants