-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/military affiliation #426
Feat/military affiliation #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid 👍
This was a mostly code review. I'll take a deeper dive in the UI on the next pass.
webroot/src/components/MilitaryDocumentRow/MilitaryDocumentRow.vue
Outdated
Show resolved
Hide resolved
webroot/src/components/SelectedStatePurchaseInformation/SelectedStatePurchaseInformation.ts
Outdated
Show resolved
Hide resolved
webroot/src/pages/UpdateMilitaryStatus/UpdateMilitaryStatus.less
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks solid. Just a few trailing items that are pretty minor.
@jlkravitz This is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! a few small nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isabeleliassen Good to merge.
Requirements List
Description List
FinalizePrivilegePurchase
page andSelectedStatePurchaseInformation
component to refer to both the state and user's military status to make a military discount determinationInputRadioGroup
component causing multi-line labels to break layoutTesting List
yarn test:unit:all
should run without errors or warningsyarn serve
should run without errors or warningsyarn build
should run without errors or warningsCloses #281
Notes: