Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

military affiliation confirmation frontend #281

Closed
isabeleliassen opened this issue Oct 29, 2024 · 1 comment · Fixed by #426
Closed

military affiliation confirmation frontend #281

isabeleliassen opened this issue Oct 29, 2024 · 1 comment · Fixed by #426
Assignees
@ChiefStief
Milestone
Privilege applica...

Comments

@isabeleliassen
Copy link
Collaborator

isabeleliassen commented Oct 29, 2024 •
edited
Loading

#327
@isabeleliassen isabeleliassen moved this to Backlog in CompactConnect Oct 30, 2024
@isabeleliassen isabeleliassen changed the title military affiliation confirmation (and option to select a license--maybe) military affiliation confirmation Nov 12, 2024
@isabeleliassen isabeleliassen changed the title military affiliation confirmation military affiliation confirmation frontend Nov 12, 2024
@ChiefStief
Copy link
Collaborator

ChiefStief commented Nov 14, 2024 •
edited
Loading

Hard to determine full complexity without knowing how this flow is intended to work.

Also in addition to the military affiliation confirmation screen I assume this ticket includes updating:

  • LicenseeDashboard screen with button
  • SelectPrivilege checking if user has military privilege and displaying prices accordingly
  • finalize purchase ui screen checking if user has military privilege and displaying prices accordingly
  • New API call or alteration to api call serialization + handling to determine if user has military affiliation

@isabeleliassen isabeleliassen moved this from Backlog to To Do in CompactConnect Dec 5, 2024
@ChiefStief ChiefStief moved this from To Do to In progress in CompactConnect Dec 18, 2024
@ChiefStief ChiefStief mentioned this issue Jan 9, 2025
Merged
@ChiefStief ChiefStief moved this from In progress to Code Review/Design Review in CompactConnect Jan 9, 2025
@jsandoval81 jsandoval81 moved this from Code Review/Design Review to CSG Review in CompactConnect Jan 10, 2025
isabeleliassen pushed a commit that referenced this issue Jan 13, 2025
@ChiefStief
Feat/military affiliation (#426)
32788ec 
### Requirements List
- A working LicenseeUser account

### Description List
- Added in Military Status page
- Added in Update Military Status page
- Added in store + network modules needed to facilitate pages'
functionality
- Updated Licensee model and serializer to capture military affiliations
api implementation
- Added military affiliations model and serializer
- Edited `FinalizePrivilegePurchase` page and
`SelectedStatePurchaseInformation` component to refer to both the state
and user's military status to make a military discount determination
- Fixed bug in `InputRadioGroup` component causing multi-line labels to
break layout
- Added / updated tests as needed

### Testing List
- `yarn test:unit:all` should run without errors or warnings
- `yarn serve` should run without errors or warnings
- `yarn build` should run without errors or warnings
- Code review
- On both mock and real api and in all screen sizes:
1) click on the view military status button to view your status page
2) Click edit info to go the doc upload page
3) Fill out the form, confirm it does not allow submission with no
select choice and no / invalid document selection
4) Submit
5) View your updated military status (real api only)
6) Go through the privilege purchase flow and notice military
affiliation discount is being applied
7) Return to the military status screen; try ending your military status
8) Status should now be inactive
9) Go back through privilege purchase flow, confirm military affiliation
is no longer being applied

Closes #281 

Notes: 

- The real API system only saves one document upload submission per day.
It will replace a prior submission in the day with your most recent one
- The document upload is eventually consistent so your status may not
immediately update. I've found it to take ~1 second but theoretically it
could be longer.

---------

Co-authored-by: Dana Stiefel <[email protected]>
@github-project-automation github-project-automation bot moved this from CSG Review to Done in CompactConnect Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChiefStief ChiefStief

Labels
None yet
Projects
CompactConnect
Status: Done
Milestone
Privilege application workflow
Development

Successfully merging a pull request may close this issue.

Feat/military affiliation InspiringApps/JCC-CompactConnect
2 participants
@ChiefStief @isabeleliassen