Skip to content

Fix last_name edge cases with Solady library #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix last_name edge cases with Solady library #2669

wants to merge 2 commits into from

Conversation

smonicas
Copy link
Collaborator

Slither does not crash anymore with Solady
Fix #2642 #2491 #2470 #2160

@smonicas smonicas requested a review from montyly as a code owner February 19, 2025 12:13
montyly added a commit that referenced this pull request Feb 20, 2025
@montyly
Improve the support for sstore/sload with simple slot access
b59cf81 
During the IR generation, convert the sstore/sload into direct IR assignement
when we have a state_variable.slot direct access

This allow the SSA to be generated correctly, and for the var read/written analyses
to use the right variables.

Fix #2642 #2491 #2470 #2160.
Replace #2669
Revert #2329
@montyly montyly mentioned this pull request Feb 20, 2025
Merged
@smonicas smonicas closed this Feb 20, 2025
@smonicas smonicas deleted the dev-fix-last-name branch February 20, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smonicas