[Bug-Candidate]: Failed to convert IR to SSA for Timelock contract

[pzy2000]

Describe the issue:

'forge clean' running (wd: /root/solady/lib/solady)
'forge config --json' running
'forge build --build-info --skip /test/* /script/* --force' running (wd: /root/solady/lib/solady)

Failed to convert IR to SSA for Timelock contract. Please open an issue https://github.com/crytic/slither/issues.

Code example to reproduce the issue:

just:
forge install solady
and
cd to /.../solady
and
run "slither ."

Version:

0.11.0

Relevant log output:

Traceback (most recent call last):
  File "/root/miniconda3/envs/tree/bin/slither", line 8, in <module>
    sys.exit(main())
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/__main__.py", line 776, in main
    main_impl(all_detector_classes=detectors, all_printer_classes=printers)
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/__main__.py", line 882, in main_impl
    ) = process_all(filename, args, detector_classes, printer_classes)
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/__main__.py", line 107, in process_all
    ) = process_single(compilation, args, detector_classes, printer_classes)
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/__main__.py", line 80, in process_single
    slither = Slither(target, ast_format=ast, **vars(args))
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slither.py", line 202, in __init__
    self._init_parsing_and_analyses(kwargs.get("skip_analyze", False))
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slither.py", line 221, in _init_parsing_and_analyses
    raise e
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slither.py", line 217, in _init_parsing_and_analyses
    parser.analyze_contracts()
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/solc_parsing/slither_compilation_unit_solc.py", line 593, in analyze_contracts
    self._convert_to_slithir()
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/solc_parsing/slither_compilation_unit_solc.py", line 834, in _convert_to_slithir
    raise e
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/solc_parsing/slither_compilation_unit_solc.py", line 829, in _convert_to_slithir
    contract.convert_expression_to_slithir_ssa()
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/core/declarations/contract.py", line 1571, in convert_expression_to_slithir_ssa
    func.generate_slithir_ssa(all_ssa_state_variables_instances)
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/core/declarations/function_contract.py", line 140, in generate_slithir_ssa
    add_ssa_ir(self, all_ssa_state_variables_instances)
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 206, in add_ssa_ir
    fix_phi_rvalues_and_storage_ref(
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 526, in fix_phi_rvalues_and_storage_ref
    fix_phi_rvalues_and_storage_ref(
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 526, in fix_phi_rvalues_and_storage_ref
    fix_phi_rvalues_and_storage_ref(
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 526, in fix_phi_rvalues_and_storage_ref
    fix_phi_rvalues_and_storage_ref(
  [Previous line repeated 18 more times]
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 496, in fix_phi_rvalues_and_storage_ref
    variables = [
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 497, in <listcomp>
    last_name(dst, ir.lvalue, init_local_variables_instances) for dst in ir.nodes
  File "/root/miniconda3/envs/tree/lib/python3.8/site-packages/slither/slithir/utils/ssa.py", line 363, in last_name
    assert candidates
AssertionError

[mslomnicki]

I have similar issue, but with other error code (in project using solady):

ERROR:SlitherSolcParsing:
Failed to convert IR to SSA for Initializable contract.

[montyly]

Thanks @pzy2000 and @mslomnicki for reporting the issue. We have fixed it with #2670, and it will be available on the next release